Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure convertDeprecationsToExceptions="true" in phpunit.xml.dist #2992

Merged
merged 3 commits into from Mar 13, 2022

Conversation

TimWolla
Copy link
Contributor

@TimWolla TimWolla commented Mar 4, 2022

No description provided.

@TimWolla
Copy link
Contributor Author

TimWolla commented Mar 4, 2022

see also: php-http/client-integration-tests#57.

@TimWolla TimWolla marked this pull request as ready for review Mar 4, 2022
.github/workflows/ci.yml Outdated Show resolved Hide resolved
Copy link
Member

@GrahamCampbell GrahamCampbell left a comment

CI failing.

@TimWolla
Copy link
Contributor Author

TimWolla commented Mar 7, 2022

Dang, sorry for that noise. I should've waited for all jobs to finish, instead of just the PHPUnit ones. Now fixed.

@TimWolla TimWolla requested a review from GrahamCampbell Mar 7, 2022
@GrahamCampbell GrahamCampbell requested a review from Nyholm Mar 7, 2022
@GrahamCampbell GrahamCampbell merged commit d12ecb1 into guzzle:master Mar 13, 2022
22 checks passed
@TimWolla TimWolla deleted the phpunit-deprecation branch Mar 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants