New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cookie with empty value #546

Merged
merged 2 commits into from Feb 5, 2014

Conversation

Projects
None yet
2 participants
@unixo
Contributor

unixo commented Jan 31, 2014

Scenario:

  • the server tries to re-set a cookie with an empty value (Cookie:isValid would return false for it)
  • the jar already contains a valid cookie with the same name

The cookie must be deleted and not used anymore in next requests.

@mtdowling

This comment has been minimized.

Show comment
Hide comment
@mtdowling

mtdowling Feb 2, 2014

Member

Sounds good to me. Can you add a test to cover this behavior?

Member

mtdowling commented Feb 2, 2014

Sounds good to me. Can you add a test to cover this behavior?

@unixo

This comment has been minimized.

Show comment
Hide comment
@unixo

unixo Feb 4, 2014

Contributor

test added

Contributor

unixo commented Feb 4, 2014

test added

@mtdowling mtdowling merged commit 805b34a into guzzle:master Feb 5, 2014

1 check passed

default The Travis CI build passed
Details
@mtdowling

This comment has been minimized.

Show comment
Hide comment
@mtdowling

mtdowling Feb 5, 2014

Member

Merged with a fix to ensure we don't remove cookies that just happen to have the same name.

Member

mtdowling commented Feb 5, 2014

Merged with a fix to ensure we don't remove cookies that just happen to have the same name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment