Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Promise.php shorter and more readable #95

Merged
merged 1 commit into from Feb 15, 2020
Merged

Conversation

@ikeyan
Copy link
Contributor

ikeyan commented Nov 10, 2018

No description provided.

@GrahamCampbell GrahamCampbell mentioned this pull request Dec 31, 2019
: $this->result;

if ($this->result instanceof PromiseInterface) {
return $this->result->wait($unwrap);

This comment has been minimized.

Copy link
@Tobion

Tobion Feb 12, 2020

Member

when $unwrap is false, the old code did not return anything at all (= null). Now it returns what the inner promise returns. I don't think it matters though.

@Tobion
Tobion approved these changes Feb 12, 2020
@Tobion

This comment has been minimized.

Copy link
Member

Tobion commented Feb 12, 2020

I had to look very precisely but it seems to do the same thing but slightly more readable.

@Tobion Tobion merged commit 89b1a76 into guzzle:master Feb 15, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.