Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reject promise instead of throwing if coroutine throws before 1st yield #98

Merged
merged 3 commits into from Feb 12, 2020

Conversation

@yched
Copy link
Contributor

yched commented Dec 21, 2018

Fixes #97

@GrahamCampbell GrahamCampbell mentioned this pull request Dec 31, 2019
Copy link
Member

Tobion left a comment

Looks good to me. Just minor coding style change required and a rebase to fix conflicts.

try {
$this->nextCoroutine($this->generator->current());
}
catch (\Exception $exception) {

This comment has been minimized.

Copy link
@Tobion

Tobion Feb 12, 2020

Member

this should be on the same line as the closing bracket. see coding style below in _handleFailure

This comment has been minimized.

Copy link
@yched

yched Feb 12, 2020

Author Contributor

Sure, done

@yched yched force-pushed the yched:fix_coroutine_throw_before_yield branch from 941e9e3 to ec78060 Feb 12, 2020
@yched yched requested a review from Tobion Feb 12, 2020
@Tobion
Tobion approved these changes Feb 12, 2020
@Tobion Tobion merged commit 4771454 into guzzle:master Feb 12, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Tobion

This comment has been minimized.

Copy link
Member

Tobion commented Feb 12, 2020

Thank you @yched

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.