Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stream modes #248

Merged
merged 5 commits into from Apr 1, 2019
Merged

Fix stream modes #248

merged 5 commits into from Apr 1, 2019

Conversation

sagikazarmark
Copy link
Member

@sagikazarmark sagikazarmark commented Dec 7, 2018

Fixes #115
Fixes #183

@sagikazarmark sagikazarmark added this to the 1.6.0 milestone Dec 7, 2018
@sagikazarmark sagikazarmark requested review from Tobion and Nyholm Dec 7, 2018
@Nyholm
Copy link
Member

@Nyholm Nyholm commented Dec 9, 2018

Good. I like this.

Could you also add tests that fails the regex? Ie b+

Because the test will still pass if I do

- const READABLE_MODES = '/r|a\+|ab\+|w\+|wb\+|x\+|xb\+|c\+|cb\+/';`
+ const READABLE_MODES = '/.*/';

@sagikazarmark
Copy link
Member Author

@sagikazarmark sagikazarmark commented Feb 20, 2019

@Nyholm Done.

Nyholm
Nyholm approved these changes Feb 20, 2019
@sagikazarmark sagikazarmark merged commit a346647 into master Apr 1, 2019
2 checks passed
@sagikazarmark sagikazarmark deleted the fix-stream-modes branch Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants