Fix stream modes #248
Merged
Fix stream modes #248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sagikazarmark
force-pushed
the
fix-stream-modes
branch
from
68822d1 to
f9423ab
Compare
Member
|
Good. I like this. Could you also add tests that fails the regex? Ie Because the test will still pass if I do - const READABLE_MODES = '/r|a\+|ab\+|w\+|wb\+|x\+|xb\+|c\+|cb\+/';`
+ const READABLE_MODES = '/.*/'; |
Member
Author
|
@Nyholm Done. |
sagikazarmark
force-pushed
the
fix-stream-modes
branch
from
f3a3c20 to
11460cd
Compare
Nyholm
approved these changes
Feb 20, 2019
sagikazarmark
force-pushed
the
fix-stream-modes
branch
from
11460cd to
aeb07f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #115
Fixes #183