Skip to content

Change minimal port number to 0 (unix socket) #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Nyholm merged 1 commit into from
May 26, 2019
Merged

Change minimal port number to 0 (unix socket) #270

Nyholm merged 1 commit into from
May 26, 2019

Conversation

@Tracerneo
Copy link

@Tracerneo Tracerneo commented Apr 15, 2019

Listening on an unix socket reports port number 0, which is interpreted as an invalid argument.

@Tracerneo Tracerneo mentioned this pull request Apr 15, 2019
Merged
@GrahamCampbell
Copy link
Member

GrahamCampbell commented May 12, 2019

👍

@sagikazarmark sagikazarmark added this to the 1.6.0 milestone May 12, 2019
@sagikazarmark sagikazarmark requested review from Nyholm and Tobion May 12, 2019 12:34
Nyholm
Nyholm approved these changes May 26, 2019
View reviewed changes
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@Nyholm Nyholm merged commit dd1ba1d into guzzle:master May 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Nyholm Nyholm Nyholm approved these changes

@Tobion Tobion Awaiting requested review from Tobion

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.6.0

Development

Successfully merging this pull request may close these issues.

4 participants

@Tracerneo @GrahamCampbell @Nyholm @sagikazarmark