Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept null and bool header values again #283

Merged
merged 2 commits into from Jul 1, 2019
Merged

Accept null and bool header values again #283

merged 2 commits into from Jul 1, 2019

Conversation

Tobion
Copy link
Member

@Tobion Tobion commented Jul 1, 2019

This is not according to PSR-7 which says @param string|string[] $value Header value(s). but for BC and missing type declarations it makes sense.

Fixes #282

@Tobion Tobion changed the title Accept null, bool and float header values again Accept null and bool header values again Jul 1, 2019
This is not according to PSR-7 which says `@param string|string[] $value Header value(s).` but for BC and missing type declarations it makes sense.
@@ -263,8 +263,7 @@ public function invalidHeaderProvider()
return [
['foo', [], 'Header value can not be an empty array.'],
['', '', 'Header name can not be empty.'],
['foo', false, 'Header value must be a string or numeric but boolean provided'],
['foo', new \stdClass(), 'Header value must be a string or numeric but stdClass provided.'],
['foo', new \stdClass(), 'Header value must be scalar or null but stdClass provided.'],
Copy link
Member

@GrahamCampbell GrahamCampbell Jul 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is there double whitespace here. ;)

@sagikazarmark sagikazarmark merged commit 239400d into 1.x Jul 1, 2019
2 checks passed
@sagikazarmark sagikazarmark deleted the null-header-value branch Jul 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants