Skip to content

Return null in caching stream size if remote is null #438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Nyholm merged 4 commits into from
Oct 4, 2021
Merged

Return null in caching stream size if remote is null #438

Nyholm merged 4 commits into from
Oct 4, 2021

Conversation

@GrahamCampbell
Copy link
Member

@GrahamCampbell GrahamCampbell commented Sep 6, 2021 •
edited
Loading

  • Tests
  • Src Change

Closes #365.

@GrahamCampbell GrahamCampbell marked this pull request as ready for review September 6, 2021 08:49
Nyholm
Nyholm approved these changes Oct 4, 2021
View reviewed changes
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@Nyholm Nyholm merged commit a0c4a5f into 1.x Oct 4, 2021
@Nyholm Nyholm deleted the caching-stream-null-remote-size branch October 4, 2021 04:32
@Nyholm Nyholm mentioned this pull request Oct 4, 2021
Closed
JanMikes referenced this pull request in JanMikes/psr7 Jan 22, 2022
@GrahamCampbell @JanMikes
Return null in caching stream size if remote is null (#438)
7e892dd 
* Return null in caching stream size if remote is null

* Added test coverage

* Fixed typo

* Fixes
JanMikes referenced this pull request in JanMikes/psr7 Jan 27, 2022
@GrahamCampbell @JanMikes
Return null in caching stream size if remote is null (#438)
3890fea 
* Return null in caching stream size if remote is null

* Added test coverage

* Fixed typo

* Fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Nyholm Nyholm Nyholm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@GrahamCampbell @Nyholm