Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More comprehensive mime type mapping #453

Merged
merged 1 commit into from Mar 13, 2022
Merged

More comprehensive mime type mapping #453

merged 1 commit into from Mar 13, 2022

Conversation

GrahamCampbell
Copy link
Member

@GrahamCampbell GrahamCampbell commented Oct 17, 2021

Uses the upstream source https://raw.githubusercontent.com/jshttp/mime-db/master/db.json. This comprehensive source is also used by https://github.com/thephpleague/mime-type-detection/blob/main/src/GeneratedExtensionToMimeTypeMap.php. We don't directly depend on that package because it contains additional extension requirements (and also lots of additional code we don't need).

@stale
Copy link

@stale stale bot commented Feb 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 2 weeks if no further activity occurs. Thank you for your contributions.

@GrahamCampbell
Copy link
Member Author

@GrahamCampbell GrahamCampbell commented Feb 17, 2022

not stale

Nyholm
Nyholm approved these changes Mar 13, 2022
Copy link
Member

@Nyholm Nyholm left a comment

Let's decide to only use this source. Ie nothing more or less.

@Nyholm Nyholm merged commit ff76777 into master Mar 13, 2022
15 checks passed
@Nyholm Nyholm deleted the comprehensive-mime-types branch Mar 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants