New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for vue-router #11

Closed
JanCVanB opened this Issue Sep 8, 2017 · 9 comments

Comments

Projects
None yet
4 participants
@JanCVanB

JanCVanB commented Sep 8, 2017

Now that Storybook supports Vue, does this project have any interest in supporting vue-router?

Link: https://github.com/vuejs/vue-router

Related: storybooks/storybook#1657

@ndelangen

This comment has been minimized.

Contributor

ndelangen commented Sep 8, 2017

Would you be interested in helping achieve support? 🙇

@JanCVanB

This comment has been minimized.

JanCVanB commented Sep 8, 2017

@ndelangen Sure! I'm very busy this month, but I'd love to help soon.

@gvaldambrini

This comment has been minimized.

Owner

gvaldambrini commented Sep 9, 2017

@JanCVanB give me some days to explore how doable / complicated is. As I'm new to Vue (and so, vue-router), any suggestion would be appreciated.

@JanCVanB

This comment has been minimized.

JanCVanB commented Sep 9, 2017

@gvaldambrini Thanks, let me know what you find+think!

@gvaldambrini

This comment has been minimized.

Owner

gvaldambrini commented Sep 30, 2017

I created an experimental branch called vue with the support to vue-router. For anyone interested just install the package from the github url:
npm install git://github.com/gvaldambrini/storybook-router.git#vue
I tried to maintain the API as similar as possible to the React one, so the decorator accepts two arguments: the links object and a config object (the router props). I'm still in an early stage so any feedback (about the code of the decorator itself or about the expected behaviour) would be really appreciated.

@ndelangen

This comment has been minimized.

Contributor

ndelangen commented Sep 30, 2017

@gvaldambrini ❤️

@gvaldambrini

This comment has been minimized.

Owner

gvaldambrini commented Oct 7, 2017

The vue support has been released. Please open a dedicated issue for any problem.

@JanCVanB

This comment has been minimized.

JanCVanB commented Oct 9, 2017

Awesome, @gvaldambrini, thanks! :D I'm excited to try it in my router-heavy project.

@kazupon

This comment has been minimized.

kazupon commented Oct 11, 2017

awesome! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment