-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: initial directories creating #698
fix: initial directories creating #698
Conversation
* (fix): do not create directory for charts exporting if 'save_charts' is False * (fix): do not create directory for cache files if 'enable_cache' is False as well * (test): update tests accordingly
WalkthroughThe recent changes primarily focus on enhancing the Changes
TipsChat with CodeRabbit Bot (
|
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## main #698 +/- ##
=======================================
Coverage 85.16% 85.17%
=======================================
Files 70 70
Lines 3552 3554 +2
=======================================
+ Hits 3025 3027 +2
Misses 527 527
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (2)
- pandasai/smart_datalake/init.py (2 hunks)
- tests/test_smartdatalake.py (1 hunks)
Files skipped from review due to trivial changes (2)
- pandasai/smart_datalake/init.py
- tests/test_smartdatalake.py
Thanks a lot for the fix @nautics889, merging! |
This PR relates to #654.
.initiliaze()
and._load_config()
methods. This allows the config object to be used in a scope of.initialize()
, and 'config first' approach looks more correct..initialize()
: create directories for charts only if "save_charts" is passed as True. Same for cache as well.Summary by CodeRabbit
SmartDatalake
class to conditionally create directories for saving charts and enabling cache based on user preferences. This change provides more flexibility and control to the user.SmartDatalake
class. This ensures the robustness of the new feature.