Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ipv4, ipv6, ethernet, and udpv4 tests for Python 3. #2

Merged
merged 4 commits into from
Apr 30, 2015
Merged

Fix ipv4, ipv6, ethernet, and udpv4 tests for Python 3. #2

merged 4 commits into from
Apr 30, 2015

Conversation

jeamland
Copy link

  • Switch to using integer division where appropriate.
  • Replace deprecated assert_ calls with assertTrue/assertFalse as needed.
  • Use bytes for expected packet payload rather than a string.
  • Add bytes prefix to strings where needed.

@jeamland
Fix ipv4 tests for Python 3.
ac374bd 
- Switch to using integer division where appropriate.
- Replace deprecated assert_ calls with assertTrue/assertFalse as needed.
- Use bytes for expected packet payload rather than a string.
@jeamland
Add bytes prefix to IPv6 packet tests.
d881be1
@jeamland jeamland changed the title Fix ipv4 tests for Python 3. Fix ipv4 and ipv6 tests for Python 3. Apr 20, 2015
@jeamland jeamland changed the title Fix ipv4 and ipv6 tests for Python 3. Fix ipv4, ipv6, ethernet, and udpv4 tests for Python 3. Apr 20, 2015
gvnn3 added a commit that referenced this pull request Apr 30, 2015
@gvnn3
Merge pull request #2 from jeamland/python3
d6e4c1c 
Fix ipv4, ipv6, ethernet, and udpv4 tests for Python 3.
@gvnn3 gvnn3 merged commit d6e4c1c into gvnn3:python3 Apr 30, 2015
uqs pushed a commit to freebsd/freebsd-ports that referenced this pull request Aug 19, 2017
net/py-pcs: Limit to Python 2.7 (Does not support Python 3)
79021fb 
This version (0.6) of the upstream package version does not appear to intend to,
or explicitly support Python 3. It also currently fails to build with Python 3.x
with a SyntaxError:

  SyntaxError: Missing parentheses in call to 'print'

This change limits the USES=python:<version-spec> support declaration to 2.7
accordingly.

Note: A closed upstream PR [1] mentions fixing tests for Python 3 in 2015, so
the version-specifier may change (be relaxed) upon future port/version updates,
or at MAINTAINER's (also the package author) discretion to explicitly mark
Python 3 as an intended supported version, *independent* to any build/run-time
issues that may exist.

While I'm here, pet portlint:

- Strip shared libraries
- Add LICENSE_FILE
- Fix section order (*_DEPENDS)

[1] gvnn3/PCS#2

PR:		219325
Reported by:	Johannes Jost Meixner
Approved by:	portmgr (blanket)
MFH:		2017Q3


git-svn-id: svn+ssh://svn.freebsd.org/ports/head@448303 35697150-7ecd-e111-bb59-0022644237b5
uqs pushed a commit to freebsd/freebsd-ports that referenced this pull request Aug 19, 2017
@koobs
MFH: r448303
2e87cdf 
net/py-pcs: Limit to Python 2.7 (Does not support Python 3)

This version (0.6) of the upstream package version does not appear to intend to,
or explicitly support Python 3. It also currently fails to build with Python 3.x
with a SyntaxError:

  SyntaxError: Missing parentheses in call to 'print'

This change limits the USES=python:<version-spec> support declaration to 2.7
accordingly.

Note: A closed upstream PR [1] mentions fixing tests for Python 3 in 2015, so
the version-specifier may change (be relaxed) upon future port/version updates,
or at MAINTAINER's (also the package author) discretion to explicitly mark
Python 3 as an intended supported version, *independent* to any build/run-time
issues that may exist.

While I'm here, pet portlint:

- Strip shared libraries
- Add LICENSE_FILE
- Fix section order (*_DEPENDS)

[1] gvnn3/PCS#2

PR:		219325
Reported by:	Johannes Jost Meixner
Approved by:	portmgr (blanket)

Approved by:	ports-secteam (blanket)
uqs pushed a commit to freebsd/freebsd-ports that referenced this pull request Aug 19, 2017
@koobs
net/py-pcs: Limit to Python 2.7 (Does not support Python 3)
60f75cf 
This version (0.6) of the upstream package version does not appear to intend to,
or explicitly support Python 3. It also currently fails to build with Python 3.x
with a SyntaxError:

  SyntaxError: Missing parentheses in call to 'print'

This change limits the USES=python:<version-spec> support declaration to 2.7
accordingly.

Note: A closed upstream PR [1] mentions fixing tests for Python 3 in 2015, so
the version-specifier may change (be relaxed) upon future port/version updates,
or at MAINTAINER's (also the package author) discretion to explicitly mark
Python 3 as an intended supported version, *independent* to any build/run-time
issues that may exist.

While I'm here, pet portlint:

- Strip shared libraries
- Add LICENSE_FILE
- Fix section order (*_DEPENDS)

[1] gvnn3/PCS#2

PR:		219325
Reported by:	Johannes Jost Meixner
Approved by:	portmgr (blanket)
MFH:		2017Q3
uqs pushed a commit to freebsd/freebsd-ports that referenced this pull request Apr 1, 2021
@koobs
MFH: r448303
900168b 
net/py-pcs: Limit to Python 2.7 (Does not support Python 3)

This version (0.6) of the upstream package version does not appear to intend to,
or explicitly support Python 3. It also currently fails to build with Python 3.x
with a SyntaxError:

  SyntaxError: Missing parentheses in call to 'print'

This change limits the USES=python:<version-spec> support declaration to 2.7
accordingly.

Note: A closed upstream PR [1] mentions fixing tests for Python 3 in 2015, so
the version-specifier may change (be relaxed) upon future port/version updates,
or at MAINTAINER's (also the package author) discretion to explicitly mark
Python 3 as an intended supported version, *independent* to any build/run-time
issues that may exist.

While I'm here, pet portlint:

- Strip shared libraries
- Add LICENSE_FILE
- Fix section order (*_DEPENDS)

[1] gvnn3/PCS#2

PR:		219325
Reported by:	Johannes Jost Meixner
Approved by:	portmgr (blanket)

Approved by:	ports-secteam (blanket)
svmhdvn pushed a commit to svmhdvn/freebsd-ports that referenced this pull request Jan 10, 2024
@koobs
net/py-pcs: Limit to Python 2.7 (Does not support Python 3)
83c3104 
This version (0.6) of the upstream package version does not appear to intend to,
or explicitly support Python 3. It also currently fails to build with Python 3.x
with a SyntaxError:

  SyntaxError: Missing parentheses in call to 'print'

This change limits the USES=python:<version-spec> support declaration to 2.7
accordingly.

Note: A closed upstream PR [1] mentions fixing tests for Python 3 in 2015, so
the version-specifier may change (be relaxed) upon future port/version updates,
or at MAINTAINER's (also the package author) discretion to explicitly mark
Python 3 as an intended supported version, *independent* to any build/run-time
issues that may exist.

While I'm here, pet portlint:

- Strip shared libraries
- Add LICENSE_FILE
- Fix section order (*_DEPENDS)

[1] gvnn3/PCS#2

PR:		219325
Reported by:	Johannes Jost Meixner
Approved by:	portmgr (blanket)
MFH:		2017Q3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jeamland @gvnn3