Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time Machine loading spinner keeps running despite 404s #1178

Open
scy opened this issue Jun 9, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@scy
Copy link

commented Jun 9, 2019

First of all, thank you for GW2Efficiency, it's an awesome tool and I wouldn't want to miss it. You're doing a great job! <3

My account has lost about 2k gold in value in the last 12 hours and I was trying to find out why, using the time machine feature.

After selecting start and end snapshot, the quaggan spinner appears, saying "Loading snapshot differences...". And then nothing happened for minutes. So I've opened up the dev tools to see whether it's actually still loading something. Turns out, no. In fact, it stopped loading after less than half a second, but doesn't tell me about it.

image

Now I guess these API calls 404ing is a bug in and of itself, but the page should handle that case gracefully, remove the spinner and show an error message.

In case you're interested: the api.gw2efficiency.com calls return {"text":"all provided ids are invalid"}, while the api.guildwars2.com call returns {"text": "all ids provided are invalid"}.

@scy scy changed the title Time Machin loading spinner keeps running despite 404s Time Machine loading spinner keeps running despite 404s Jun 9, 2019

@queicherius

This comment has been minimized.

Copy link
Member

commented Jun 9, 2019

The API is currently experiencing issues which caused most recipes and item prices to disappear = all accounts to drop in value (and is also the reason that those API calls 404). Nothing we can do at the moment, but as soon as it's fixed it will fix itself on the site too.

Agree that it should show an error tho.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.