Fix typo in ACT that's printed to screen #3402
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ensemble samplers have a bug in the ACT that's printed to screen when the ACL is computed. They should report the acl times the file's
thinned_by
attribute (which is the thinning used when writing samples to file), but instead are printing the ACL times the file'sthin_interval
attribute (which is how many samples to skip to get a posterior). The latter is the ACL, so it's actually reporting the ACL squared rather than the ACT. This fixes that.This bug actually affect anything, since the true ACT is calculated elsewhere (correctly), but it does make it confusing when looking at the messages being printed to screen while
pycbc_inference
is running.