Make sure overwrite flag is actually valid #1

Merged
merged 1 commit into from May 25, 2016

Projects

None yet

2 participants

@henrinormak
Contributor

Previously, the flag could never have been set to true.

SIDENOTE: Awesome library! I will potentially file a few more PRs/Issues (for example, having the script determine "safe" throughput options based on the table value, i.e you give it a percentage, rather than a fixed value).

@henrinormak henrinormak Make sure overwrite flag is actually valid
Previously, the flag could never have been set to true.
c82ff3f
@gwatts
Owner
gwatts commented May 25, 2016

Thanks for the PR; good catch!

Being able to specify a percentage for read/write capacity is something I'd considered for a future update, so a PR on that would be great.

I'd also thought about having an option to dynamically increase the capacity on the table by a percentage and then drop it again once the operation completed. A somewhat bigger update, but not bad. Useful if you're only dumping occasionally given the limit of 4 downsizes/day.

@gwatts gwatts merged commit acc5f49 into gwatts:master May 25, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@gwatts gwatts added the bug label May 25, 2016
@gwatts gwatts self-assigned this May 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment