Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Finish implementing forms. #42

Closed
dominikmayer opened this Issue Mar 26, 2012 · 18 comments

Comments

Projects
None yet
3 participants

@dominikmayer dominikmayer was assigned Apr 7, 2012

Owner

caarlos0 commented Apr 27, 2012

What features are still missing?

Owner

dominikmayer commented Apr 27, 2012

Are the whole label/action things working? I can't do a git pull until I finished another project where I can't risk to introduce a bug. Won't take much longer. After that I can continue working on GWT-Bootstrap.

Owner

soundTricker commented Apr 27, 2012

OK.I'll make any form input widgets.
Day after tomorrow , I'll make TextBox,CheckBox,RadioButton.
and I think we have to make html5 form attribute, placeholder and more.
maybe They are provided some interface like HasPlaceholder.

Owner

caarlos0 commented Apr 27, 2012

I agreed with you, @soundTricker .

I think we have to made our own TextBox, e.g., with placeholder attribute :)
Maybe I can do this later..

Owner

soundTricker commented May 6, 2012

add CheckBox,RadioButton,PasswordTextBox.

Umm......
I should add sooooo many widget..........
I should create...

  • ListBox (maybe support Editor Framework)
  • Fileupload
  • Textarea

and more?

Owner

soundTricker commented May 6, 2012

Maybe implementing uneditable view of TextBox is so difficult.
I don't know how to replace from input to span or from span to input tag in the code.

Owner

caarlos0 commented May 6, 2012

hmmm... I'll try in something...

Owner

soundTricker commented May 6, 2012

👍

Owner

soundTricker commented May 15, 2012

@dominikmayer
Hi dominik.
I have one question.
Why did not you extends our Form class from GWT's FormPanel?
I guess its reason is GWT's FormPanel can't add some widgets.
Is there other reason?

I want to add new another Form class that extends GWT's FormPanel.
GWT's FormPanel can submit without move page using iframe.
I think our user wants it.

Owner

caarlos0 commented May 15, 2012

Owner

dominikmayer commented May 15, 2012

I think it was the thing with the widgets. FormPanel is a SimplePanel.

Owner

soundTricker commented May 15, 2012

Thanks @dominikmayer . ;-)
I'll implement like our Form this comment or this.

Owner

soundTricker commented May 17, 2012

I finished implement ListBox and FileUpload in my local machine.

I want to separate issue for Creating AutoForm.
Maybe Creating AutoForm is needed long time.

Owner

caarlos0 commented May 17, 2012

It's OK for me. 👍

Owner

soundTricker commented May 17, 2012

Yeah.
I'll push ListBox and FileUpload and push its showcase,then I'll create new Task Issue Create AutoForm feature.

My thinking...
AutoForm feature is implemented in our Form.
The user can choose using AutoForm feature or not by setAutoForm(boolean) or <b:Form autoForm="true">.

Owner

caarlos0 commented May 17, 2012

OK. I have commited the showcase with datebox right now , take a look :)

Owner

soundTricker commented May 17, 2012

👍

Owner

soundTricker commented Jun 8, 2012

I think the Form implemention is finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment