Skip to content

Greg Lazarev
gylaz

Organizations

@thoughtbot @rails-school @houndci
May 27, 2016
@gylaz
gylaz deleted branch gl-better-admin-formatting at houndci/hound
May 27, 2016
May 27, 2016
gylaz pushed to master at houndci/hound
@gylaz
  • @gylaz 37eb6e2
    Improve formatting of failed jobs admin page
May 27, 2016
gylaz merged pull request houndci/hound#1137
@gylaz
Improve formatting of failed jobs admin page
1 commit with 27 additions and 14 deletions
May 27, 2016
gylaz commented on pull request houndci/hound#1137
@gylaz

Yes... ? Without this I get the following error:

May 27, 2016
@gylaz
May 26, 2016
gylaz commented on pull request houndci/hound#1144
@gylaz

Nice cleanup! 🎂

May 26, 2016
gylaz commented on pull request houndci/hound#1144
@gylaz

How about instance_double here and line 23?

May 26, 2016
gylaz commented on pull request houndci/hound#1144
@gylaz

How about still keeping this as linter_name? Benefits? Less diff noise, and config.linter_name is a bit more self-explanatory.

May 26, 2016
gylaz commented on pull request houndci/hound#1143
@gylaz

Is it worth asserting this too, to be sure that jshint is also disabled?

May 26, 2016
gylaz commented on pull request houndci/hound#1143
@gylaz

To be clear, I'm proposing this instead of CONFIGURABLE_LINTERS.

May 26, 2016
gylaz commented on pull request houndci/hound#1143
@gylaz

Rather than having another array, can we leverage the Linter::Collection::LINTERS array? This would also allow us to use the aliases, and check those.

May 26, 2016
gylaz commented on pull request houndci/hound#1143
@gylaz

We could add # frozen_string_literal: true to the top of the file.

May 26, 2016
@gylaz
  • @gylaz ec73f38
    Add weight for current direction
May 26, 2016
@gylaz
May 26, 2016
@gylaz
  • @gylaz 5e08a9a
    Increase moves per second
May 26, 2016
@gylaz
  • @gylaz 738df64
    Implement ability to turn for worms
May 25, 2016
gylaz commented on pull request houndci/hound#1142
@gylaz

:shipit:

May 25, 2016
gylaz commented on pull request houndci/hound#1142
@gylaz

I really wanted to add a JS spec for this, but it feels like a lot of work given how little I know of angular/jasmine. I did verify that the event…

May 25, 2016
gylaz commented on pull request houndci/hound#1142
@gylaz

Hmm, I have a vague recollection of CoffeeLint doing that. If so, I wonder why it didn't catch this.

May 25, 2016
gylaz commented on pull request houndci/hound#1142
@gylaz

What is the value of moving this event tracking from server-side to client-side? /cc @croaky

May 24, 2016
gylaz commented on pull request houndci/hound#1142
@gylaz

Yes, catch should fire for all failures (even those that can happen in then's success). What do you think about bringing .then on a new line, like c…

May 24, 2016
gylaz commented on pull request houndci/hound#1140
@gylaz

LGTM.

May 24, 2016
gylaz commented on pull request houndci/hound#1140
@gylaz

Capitalize to Hound in the whole file?

May 24, 2016
gylaz commented on pull request houndci/hound#1140
@gylaz

Why is this line indented but not the next?

May 24, 2016
gylaz commented on pull request houndci/hound#1140
@gylaz

Same here? 👀

May 24, 2016
gylaz commented on pull request houndci/hound#1140
@gylaz

Is there a space before Ngrok? Also, capitalize Hound?

May 24, 2016
May 24, 2016
gylaz commented on pull request houndci/hound#1140
@gylaz

The new version of ngrok uses a different domain, ngrok.io Might be a good idea to update .env too.

May 24, 2016
gylaz commented on pull request houndci/hound#1141
@gylaz

👍

Something went wrong with that request. Please try again.