return length and width from utils::prefix(_length)#107
Merged
gyscos merged 1 commit intogyscos:masterfrom Feb 1, 2017
Merged
Conversation
gyscos
reviewed
Feb 1, 2017
src/utils/mod.rs
Outdated
| @@ -34,7 +42,7 @@ pub use self::reader::ProgressReader; | |||
| /// prefix_length(my_text.graphemes(true), 5, ""); | |||
Owner
There was a problem hiding this comment.
Just need to update the doc comment here and it should be fine.
Thanks!
Contributor
Author
There was a problem hiding this comment.
Sorry, I need to remember that cargo build may not be enough (fixed by amending)
…fix_length()) as per df835d1
Owner
|
Looks good! Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I considered using a tuple but that is not as readable. Also I hope you find it OK to rename
prefix_lengthtoprefixas I think that makes more sense now that it returns aPrefixthat contains not only the length.see df835d1