Skip to content

Rename the desktop entry file to match the application ID #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

cheese
Copy link

@cheese cheese commented Jun 30, 2021

GNOME Shell requires this to load application icon and prepare
sandboxing[1].

[1] https://wiki.gnome.org/Projects/GnomeShell/ApplicationBased

GNOME Shell requires this to load application icon and prepare
sandboxing[1].

[1] https://wiki.gnome.org/Projects/GnomeShell/ApplicationBased
@u-235
Copy link
Contributor

u-235 commented Jun 30, 2021

But this is a requirement for GTK-based applications, right? Is the sandbox a flatpack? Wouldn't it be better to rename the file when bundling?

@cheese
Copy link
Author

cheese commented Jun 30, 2021

But this is a requirement for GTK-based applications, right?

Not just for GTK-based applications. It is for any application that aim for better integration with GNOME Shell.

Is the sandbox a flatpack?

Here does not mean for the flatpak level sandboxing. Just the GNOME Shell level. But renaming the desktop file is even obligatory for flatpak.

Wouldn't it be better to rename the file when bundling?

Renaming will make all packagers happy. Casual packager may not even know what the application ID is.

@cheese
Copy link
Author

cheese commented Jul 12, 2021

This is not the best solution. Upstream should decide an explicit application ID and set it by QGuiApplication::setDesktopFileName. And then rename the desktop entry file according to that.

For example:

#if QT_VERSION >= QT_VERSION_CHECK(5, 7, 0)
  QGuiApplication::setDesktopFileName("net.kchmviewer.KchmViewer");
#endif

@cheese cheese closed this Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants