Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always use core::arch #38

Merged
merged 1 commit into from Jan 20, 2021
Merged

Always use core::arch #38

merged 1 commit into from Jan 20, 2021

Conversation

niklasf
Copy link
Contributor

@niklasf niklasf commented Jan 15, 2021

Hi, does this crate have a policy for the minimum supported Rust version? It would be a fair bit lighter after dropping support for Rust 1.26.x. I did not delete the feature flags for bc, although I guess no outside crate should set them.

@gz
Copy link
Owner

@gz gz commented Jan 15, 2021

Hi, Thanks for submitting this pull request. Always happy to remove bit-cruft.

Because this crate is transitively used quite a bit, ideally there would be some data on how much rust <1.26 is still in use but I'm not aware of any data on this, are you?

@niklasf
Copy link
Contributor Author

@niklasf niklasf commented Jan 15, 2021

Not sure if anyone has usage data. I checked the status the most frequently downloaded crates:

crate msrv
rand 1.36
syn, quote 1.31
libc 1.13
bitflags 1.20
serde 1.13
log 1.31
... ...
serde_derive (!) 1.31
tokio 1.45

Then there's the Rust user survey results: https://blog.rust-lang.org/2020/12/16/rust-survey-2020.html#stability

And 1.34 is the oldest rustc in Debian ... usually pretty conservative.

There's a fair bit of controversy if and when bumping msrv is considered a breaking change: https://users.rust-lang.org/t/rust-version-requirement-change-as-semver-breaking-or-not/20980

@niklasf
Copy link
Contributor Author

@niklasf niklasf commented Jan 17, 2021

Perhaps most convincing is that cc (a dependency in the fallback code!), now uses rustc 1.34 as the minimum supported Rust version: rust-lang/cc-rs@c668e9e. So unless cc is pinned to an older version, the fallback is broken anyway.

@gz
Copy link
Owner

@gz gz commented Jan 20, 2021

Perfect, in that case I think we can safely merge this.

@gz gz merged commit 90a1a3b into gz:master Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants