Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break compilation on SGX and 32-bit x86 without SSE (fixes #41) #44

Merged
merged 1 commit into from Jan 21, 2021

Conversation

niklasf
Copy link
Contributor

@niklasf niklasf commented Jan 21, 2021

A possible fix for #41.

Unfortunately this would break compilation for 32-bit targets without SSE, a few of which would support CPUID. Proper runtime detection would look like https://doc.rust-lang.org/stable/src/core/up/up/stdarch/crates/core_arch/src/x86/cpuid.rs.html#110-156, but needs C again, to accomplish it on stable Rust.

@gz
Copy link
Owner

@gz gz commented Jan 21, 2021

Thanks for submitting this!

It's pretty rare to have 32bit environments today anyways (especially without SSE), and the poor souls that have to run these machines probably aren't running rust based software on it -- so this seems like a good fix to me!

@gz gz merged commit 643c4d8 into gz:master Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants