Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

throw unimplemented errors #332

Merged
merged 8 commits into from
Jul 12, 2022
Merged

throw unimplemented errors #332

merged 8 commits into from
Jul 12, 2022

Conversation

weswalla
Copy link
Contributor

@weswalla weswalla commented Jul 7, 2022

closes #323

@Connoropolous
Copy link
Contributor

Nice. Which ones have we vetted so far between you and me?

@weswalla
Copy link
Contributor Author

weswalla commented Jul 7, 2022

@Connoropolous covered all the ones outlined in #323

Base automatically changed from read-all-endpoint-resolvers to sprout July 8, 2022 14:32
@Connoropolous
Copy link
Contributor

@weswalla check out the issue again, I've updated it with what I hope is the full list

@Connoropolous Connoropolous merged commit 3bd2e2c into sprout Jul 12, 2022
@Connoropolous Connoropolous deleted the feature/323-throw-unimplemented-error branch July 12, 2022 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Connoropolous Connoropolous Connoropolous approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

throw 'unimplemented' errors for API queries that aren't and won't be implemented within MMR scope
2 participants
@weswalla @Connoropolous