Issue #3089: GREATEST and LEAST aren't fully compliant with the SQL Standard
diff --git a/h2/src/java21/precompiled/org/h2/util/Utils21.class b/h2/src/java21/precompiled/org/h2/util/Utils21.class
new file mode 100644
index 0000000000..65e131486e
Binary files /dev/null and b/h2/src/java21/precompiled/org/h2/util/Utils21.class differ
diff --git a/h2/src/java21/src/org/h2/util/Utils21.java b/h2/src/java21/src/org/h2/util/Utils21.java
new file mode 100644
index 0000000000..cd0401b658
--- /dev/null
+++ b/h2/src/java21/src/org/h2/util/Utils21.java
@@ -0,0 +1,36 @@
+/*
+ * Copyright 2004-2023 H2 Group. Multiple-Licensed under the MPL 2.0,
+ * and the EPL 1.0 (https://h2database.com/html/license.html).
+ * Initial Developer: H2 Group
+ */
+package org.h2.util;
+
+import java.lang.Thread.Builder.OfVirtual;
+
+/**
+ * Utilities with specialized implementations for Java 21 and later versions.
+ *
+ * This class contains basic implementations for older versions of Java and it
+ * is overridden in multi-release JARs.
+ */
+public final class Utils21 {
+
+ private static final OfVirtual VIRTUAL_THREAD_BUILDER = Thread.ofVirtual();
+
+ /**
+ * Creates a new virtual thread (on Java 21+) for the specified task. Use
+ * {@link Thread#start()} to schedule the thread to execute. On older
+ * versions of Java a platform daemon thread is created instead.
+ *
+ * @param task
+ * the object to run
+ * @return a new thread
+ */
+ public static Thread newVirtualThread(Runnable task) {
+ return VIRTUAL_THREAD_BUILDER.unstarted(task);
+ }
+
+ private Utils21() {
+ }
+
+}
diff --git a/h2/src/java21/src/org/h2/util/package.html b/h2/src/java21/src/org/h2/util/package.html
new file mode 100644
index 0000000000..07363d4a39
--- /dev/null
+++ b/h2/src/java21/src/org/h2/util/package.html
@@ -0,0 +1,14 @@
+
+
+
+
+Javadoc package documentation
+
+
+Internal utility classes reimplemented for Java 21 and later versions.
+
+
\ No newline at end of file
diff --git a/h2/src/main/org/h2/server/TcpServer.java b/h2/src/main/org/h2/server/TcpServer.java
index 49d580123d..ca7b3a64fb 100644
--- a/h2/src/main/org/h2/server/TcpServer.java
+++ b/h2/src/main/org/h2/server/TcpServer.java
@@ -26,7 +26,9 @@
import org.h2.util.NetUtils;
import org.h2.util.StringUtils;
import org.h2.util.Tool;
+import org.h2.util.Utils;
import org.h2.util.Utils10;
+import org.h2.util.Utils21;
/**
* The TCP server implements the native H2 database server protocol.
@@ -62,6 +64,7 @@ public class TcpServer implements Service {
private boolean allowOthers;
private boolean isDaemon;
private boolean ifExists = true;
+ private boolean virtualThreads;
private JdbcConnection managementDb;
private PreparedStatement managementDbAdd;
private PreparedStatement managementDbRemove;
@@ -182,6 +185,8 @@ public void init(String... args) {
allowOthers = true;
} else if (Tool.isOption(a, "-tcpDaemon")) {
isDaemon = true;
+ } else if (Tool.isOption(a, "-tcpVirtualThreads")) {
+ virtualThreads = Utils.parseBoolean(args[++i], virtualThreads, true);
} else if (Tool.isOption(a, "-ifExists")) {
ifExists = true;
} else if (Tool.isOption(a, "-ifNotExists")) {
@@ -256,8 +261,14 @@ public void listen() {
int id = nextThreadId++;
TcpServerThread c = new TcpServerThread(s, this, id);
running.add(c);
- Thread thread = new Thread(c, threadName + " thread-" + id);
- thread.setDaemon(isDaemon);
+ Thread thread;
+ if (virtualThreads) {
+ thread = Utils21.newVirtualThread(c);
+ } else {
+ thread = new Thread(c);
+ thread.setDaemon(isDaemon);
+ }
+ thread.setName(threadName + " thread-" + id);
c.setThread(thread);
thread.start();
}
diff --git a/h2/src/main/org/h2/server/pg/PgServer.java b/h2/src/main/org/h2/server/pg/PgServer.java
index 1135c9f3a5..a479d2316c 100644
--- a/h2/src/main/org/h2/server/pg/PgServer.java
+++ b/h2/src/main/org/h2/server/pg/PgServer.java
@@ -19,7 +19,9 @@
import org.h2.server.Service;
import org.h2.util.NetUtils;
import org.h2.util.Tool;
+import org.h2.util.Utils;
import org.h2.util.Utils10;
+import org.h2.util.Utils21;
import org.h2.value.TypeInfo;
import org.h2.value.Value;
@@ -79,6 +81,7 @@ public class PgServer implements Service {
private boolean allowOthers;
private boolean isDaemon;
private boolean ifExists = true;
+ private boolean virtualThreads;
private String key, keyDatabase;
@Override
@@ -97,6 +100,8 @@ public void init(String... args) {
allowOthers = true;
} else if (Tool.isOption(a, "-pgDaemon")) {
isDaemon = true;
+ } else if (Tool.isOption(a, "-pgVirtualThreads")) {
+ virtualThreads = Utils.parseBoolean(args[++i], virtualThreads, true);
} else if (Tool.isOption(a, "-ifExists")) {
ifExists = true;
} else if (Tool.isOption(a, "-ifNotExists")) {
@@ -197,8 +202,14 @@ public void listen() {
running.add(c);
int id = pid.incrementAndGet();
c.setProcessId(id);
- Thread thread = new Thread(c, threadName + " thread-" + id);
- thread.setDaemon(isDaemon);
+ Thread thread;
+ if (virtualThreads) {
+ thread = Utils21.newVirtualThread(c);
+ } else {
+ thread = new Thread(c);
+ thread.setDaemon(isDaemon);
+ }
+ thread.setName(threadName + " thread-" + id);
c.setThread(thread);
thread.start();
}
diff --git a/h2/src/main/org/h2/server/web/WebServer.java b/h2/src/main/org/h2/server/web/WebServer.java
index a134634a46..32d7664574 100644
--- a/h2/src/main/org/h2/server/web/WebServer.java
+++ b/h2/src/main/org/h2/server/web/WebServer.java
@@ -177,6 +177,7 @@ public class WebServer implements Service {
private ShutdownHandler shutdownHandler;
private Thread listenerThread;
private boolean ifExists = true;
+ boolean virtualThreads;
private String key;
private boolean allowSecureCreation;
private boolean trace;
@@ -336,6 +337,8 @@ public void init(String... args) {
setExternalNames(args[++i]);
} else if (Tool.isOption(a, "-webDaemon")) {
isDaemon = true;
+ } else if (Tool.isOption(a, "-webVirtualThreads")) {
+ virtualThreads = Utils.parseBoolean(args[++i], virtualThreads, true);
} else if (Tool.isOption(a, "-baseDir")) {
String baseDir = args[++i];
SysProperties.setBaseDir(baseDir);
diff --git a/h2/src/main/org/h2/server/web/WebThread.java b/h2/src/main/org/h2/server/web/WebThread.java
index cdcaf98c50..fa871c7fcb 100644
--- a/h2/src/main/org/h2/server/web/WebThread.java
+++ b/h2/src/main/org/h2/server/web/WebThread.java
@@ -25,6 +25,7 @@
import org.h2.util.NetworkConnectionInfo;
import org.h2.util.StringUtils;
import org.h2.util.Utils;
+import org.h2.util.Utils21;
/**
* For each connection to a session, an object of this class is created.
@@ -47,7 +48,8 @@ class WebThread extends WebApp implements Runnable {
WebThread(Socket socket, WebServer server) {
super(server);
this.socket = socket;
- thread = new Thread(this, "H2 Console thread");
+ thread = server.virtualThreads ? Utils21.newVirtualThread(this) : new Thread(this);
+ thread.setName("H2 Console thread");
}
/**
diff --git a/h2/src/main/org/h2/tools/Console.java b/h2/src/main/org/h2/tools/Console.java
index 86f025c849..6395728185 100644
--- a/h2/src/main/org/h2/tools/Console.java
+++ b/h2/src/main/org/h2/tools/Console.java
@@ -117,6 +117,8 @@ public void runTool(String... args) throws SQLException {
i++;
} else if ("-webDaemon".equals(arg)) {
// no parameters
+ } else if ("-webVirtualThreads".equals(arg)) {
+ i++;
} else if ("-webSSL".equals(arg)) {
// no parameters
} else if ("-webPort".equals(arg)) {
@@ -140,6 +142,8 @@ public void runTool(String... args) throws SQLException {
// no parameters
} else if ("-tcpDaemon".equals(arg)) {
// no parameters
+ } else if ("-tcpVirtualThreads".equals(arg)) {
+ i++;
} else if ("-tcpSSL".equals(arg)) {
// no parameters
} else if ("-tcpPort".equals(arg)) {
@@ -163,6 +167,8 @@ public void runTool(String... args) throws SQLException {
// no parameters
} else if ("-pgDaemon".equals(arg)) {
// no parameters
+ } else if ("-pgVirtualThreads".equals(arg)) {
+ i++;
} else if ("-pgPort".equals(arg)) {
i++;
} else {
diff --git a/h2/src/main/org/h2/tools/Server.java b/h2/src/main/org/h2/tools/Server.java
index be6076fa38..9d453d0fc2 100644
--- a/h2/src/main/org/h2/tools/Server.java
+++ b/h2/src/main/org/h2/tools/Server.java
@@ -71,6 +71,8 @@ public Server(Service service, String... args) throws SQLException {
* used together with -webAllowOthers
* | [-webDaemon] |
* Use a daemon thread |
+ * | [-webVirtualThreads <true|false>] |
+ * Use virtual threads (on Java 21+ only) |
* | [-webPort <port>] |
* The port (default: 8082) |
* | [-webSSL] |
@@ -89,6 +91,8 @@ public Server(Service service, String... args) throws SQLException {
* Allow other computers to connect - see below |
* | [-tcpDaemon] |
* Use a daemon thread |
+ * | [-tcpVirtualThreads <true|false>] |
+ * Use virtual threads (on Java 21+ only) |
* | [-tcpPort <port>] |
* The port (default: 9092) |
* | [-tcpSSL] |
@@ -105,6 +109,8 @@ public Server(Service service, String... args) throws SQLException {
* Allow other computers to connect - see below |
* | [-pgDaemon] |
* Use a daemon thread |
+ * | [-pgVirtualThreads <true|false>] |
+ * Use virtual threads (on Java 21+ only) |
* | [-pgPort <port>] |
* The port (default: 5435) |
* | [-properties "<dir>"] |
@@ -148,6 +154,8 @@ private void verifyArgs(String... args) throws SQLException {
i++;
} else if ("-webDaemon".equals(arg)) {
// no parameters
+ } else if ("-webVirtualThreads".equals(arg)) {
+ i++;
} else if ("-webSSL".equals(arg)) {
// no parameters
} else if ("-webPort".equals(arg)) {
@@ -169,6 +177,8 @@ private void verifyArgs(String... args) throws SQLException {
// no parameters
} else if ("-tcpDaemon".equals(arg)) {
// no parameters
+ } else if ("-tcpVirtualThreads".equals(arg)) {
+ i++;
} else if ("-tcpSSL".equals(arg)) {
// no parameters
} else if ("-tcpPort".equals(arg)) {
@@ -189,6 +199,8 @@ private void verifyArgs(String... args) throws SQLException {
// no parameters
} else if ("-pgDaemon".equals(arg)) {
// no parameters
+ } else if ("-pgVirtualThreads".equals(arg)) {
+ i++;
} else if ("-pgPort".equals(arg)) {
i++;
} else {
diff --git a/h2/src/main/org/h2/util/Utils21.java b/h2/src/main/org/h2/util/Utils21.java
new file mode 100644
index 0000000000..7adca6142b
--- /dev/null
+++ b/h2/src/main/org/h2/util/Utils21.java
@@ -0,0 +1,40 @@
+/*
+ * Copyright 2004-2023 H2 Group. Multiple-Licensed under the MPL 2.0,
+ * and the EPL 1.0 (https://h2database.com/html/license.html).
+ * Initial Developer: H2 Group
+ */
+package org.h2.util;
+
+/**
+ * Utilities with specialized implementations for Java 21 and later versions.
+ *
+ * This class contains basic implementations for older versions of Java and it
+ * is overridden in multi-release JARs.
+ */
+public final class Utils21 {
+
+ /*
+ * Signatures of methods should match with
+ * h2/src/java21/src/org/h2/util/Utils21.java and precompiled
+ * h2/src/java21/precompiled/org/h2/util/Utils21.class.
+ */
+
+ /**
+ * Creates a new virtual thread (on Java 21+) for the specified task. Use
+ * {@link Thread#start()} to schedule the thread to execute. On older
+ * versions of Java a platform daemon thread is created instead.
+ *
+ * @param task
+ * the object to run
+ * @return a new thread
+ */
+ public static Thread newVirtualThread(Runnable task) {
+ Thread thread = new Thread(task);
+ thread.setDaemon(true);
+ return thread;
+ }
+
+ private Utils21() {
+ }
+
+}
diff --git a/h2/src/main/org/h2/value/Value.java b/h2/src/main/org/h2/value/Value.java
index 7a8e12bbc0..5047a31b55 100644
--- a/h2/src/main/org/h2/value/Value.java
+++ b/h2/src/main/org/h2/value/Value.java
@@ -2711,7 +2711,7 @@ public boolean containsNull() {
* Scans this and specified values until a first NULL occurrence and returns
* a value where NULL appears earlier, or {@code null} if these two values
* have first NULL on the same position.
- *
+ *
* @param v
* a value of the same data type as this value, must be neither
* equal to nor smaller than nor greater than this value
diff --git a/h2/src/tools/org/h2/build/Build.java b/h2/src/tools/org/h2/build/Build.java
index a55d5fbe40..05d8d333ad 100644
--- a/h2/src/tools/org/h2/build/Build.java
+++ b/h2/src/tools/org/h2/build/Build.java
@@ -557,6 +557,7 @@ private FileList excludeTestMetaInfFiles(FileList files) {
private void addVersions() {
copy("temp/META-INF/versions/9", files("src/java9/precompiled"), "src/java9/precompiled");
copy("temp/META-INF/versions/10", files("src/java10/precompiled"), "src/java10/precompiled");
+ copy("temp/META-INF/versions/21", files("src/java21/precompiled"), "src/java21/precompiled");
}
/**
@@ -922,6 +923,9 @@ private void test(boolean ci) {
cp = "src/java9/precompiled" + File.pathSeparator + cp;
if (version >= 10) {
cp = "src/java10/precompiled" + File.pathSeparator + cp;
+ if (version >= 21) {
+ cp = "src/java21/precompiled" + File.pathSeparator + cp;
+ }
}
}
int ret;
diff --git a/h2/src/tools/org/h2/build/doc/dictionary.txt b/h2/src/tools/org/h2/build/doc/dictionary.txt
index 11554ccb57..60478ced41 100644
--- a/h2/src/tools/org/h2/build/doc/dictionary.txt
+++ b/h2/src/tools/org/h2/build/doc/dictionary.txt
@@ -855,4 +855,4 @@ duplicating unnested hardening sticky massacred
bck clo cur hwm materializedview udca vol connectionpooldatasource xadatasource
ampm sssssff sstzh tzs yyyysssss newsequentialid solidus openjdk furthermore ssff secons nashorn fractions
btrim underscores ffl decomposed decomposition subfield infinities retryable salted establish
-hatchet fis loom birthdate penrosed eve graalvm roberto polyglot truffle scriptengine
+hatchet fis loom birthdate penrosed eve graalvm roberto polyglot truffle scriptengine unstarted