Ifexists#1580
Merged
Merged
Conversation
…to isuruperera-master
And add an -ifNotExists option to turn on the permissive behaviour Related to https://www.exploit-db.com/exploits/45506 even though we document that you should set this in http://www.h2database.com/html/advanced.html#remote_access people turn on network access but don't turn on -ifExists.
Contributor
|
It is nice to have that warm, fuzzy feeling that we are “secure” now! 8-) |
it needs -ifNotExists since it tests for creating a DB automatically
Contributor
|
@grandinj Do you have time to complete these changes? I can pull these changes and try to adjust test cases for them. |
Contributor
|
I guess the main problem here is the lack of |
Contributor
Author
|
@katzyn don't have time right now. The main problem currently is plumbing -ifNotExists through for the network case, where we want to fire up a TcpServer and somehow tell it that it should create databases on demand. But maybe you have a better solution? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And add an -ifNotExists option to turn on the permissive behaviour
Related to https://www.exploit-db.com/exploits/45506
even though we document that you should set this in
http://www.h2database.com/html/advanced.html#remote_access
people turn on network access but don't turn on -ifExists.