Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop salt as suggested in #194 #200

Merged
merged 1 commit into from May 3, 2018
Merged

Drop salt as suggested in #194 #200

merged 1 commit into from May 3, 2018

Conversation

philhug
Copy link
Contributor

@philhug philhug commented May 2, 2018

Drop the signature salt as discussed in #194

Copy link
Collaborator

@Dynom Dynom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@h2non h2non merged commit d48f428 into h2non:master May 3, 2018
@philhug philhug deleted the drop-salt branch May 5, 2018 12:56
zhenqianz added a commit to kumparan/imaginary that referenced this pull request Aug 2, 2018
* fix(docs): Docker image link

* refactor(docs): use preinstall.sh script from bimg repository

* refactor(docs): update preinstall.sh install URL

* refactor(docs): remove deprecated sharp benchmark results

* fix(usage): correct help message of 'allowed-origins'

* feat(max-allowed-size): add new option max-allowed-size in bytes (h2non#111)

* feat(max-allowed-size): add new option max-allowed-size in bytes

* fix(max-allowed-size): HEAD response handling

- consider 200~206 as valid HEAD response codes
- do not defer res.Body.Close() of HEAD request

* feat(version): bump to 0.1.29

* Update History.md

* fix(type): bimg v1.0.7 integration

* fix(type): bimg v1.0.7 integration

* fix(tests): integration with bimg v1.0.7

* Update .travis.yml

* fix(travis): use proper preinstall.sh URL

* feat(travis): add multi libvips testing environments

* fix(travis): remove libvips 8.5

* feat(History): update changes

* feat(version): bump to v0.1.30

* refacgor(version): add comments

* 1. remove the .godir as Heroku and Cloud Foundry remove the support. (h2non#117)

For the details, pls reference https://github.com/heroku/heroku-buildpack-go/blob/d21f5d37c9a7ca59349d6bb3a55aa1eb3607b570/CHANGELOG.md#v23-2015-12-17
2. Ignore the glide.lock

* Add backers & sponsors from open collective (h2non#119)

your open collective backers and sponsors can now appear directly on your readme. 
see how it'll look: https://github.com/apex/apex#backers
More info: https://github.com/opencollective/opencollective/wiki/Github-banner
Also add badges on top

* Deploy on Cloud Foundry PaaS (h2non#122)

* 1. remove the .godir as Heroku and Cloud Foundry remove the support.
  For the details, pls reference https://github.com/heroku/heroku-buildpack-go/blob/d21f5d37c9a7ca59349d6bb3a55aa1eb3607b570/CHANGELOG.md#v23-2015-12-17
2. Ignore the glide.lock

* Add the steps for the deployment on cloudfoundry

* fix(h2non#124): fast workaround to unblock Heroku deployment until the buildpack can be updated

* fix(.godir): add project name

* feat(docs): add maintainers section

* refactor(docs): update support badges

* feat(travis): use Go 1.8

* feat(docs): add new maintainer notice (thanks to @kirillDanshin)

* fix(docs): move toc top level sections

* Correcting the documentation, caching headers are always sent, regardless of being fetched from mount or by URL. (h2non#133)

* feat(Dockerfile): use libvips v8.5.5, Go v1.8.1 and bimg v1.0.8

* feat(version): bump to 0.1.31

* feat(History): update latest changes

* Supporting smart crop (h2non#136)

* Using bimg's new SmartCrop API

* Minor tweaks and fixes

* Allowing pre Go 1.5 versions to fail.

* feat(History): update changes

* feat(version): bump to v1.0.0

* feat(controllers): add smart crop form

* refactor(controller): add height for smart crop form

* feat(h2non#140): expose Content-Length header

* feat(version): bump to v1.0.1

* feat(changelog): update v1.0.1 changes

* feat(Docker): upgrade Go to v1.8.3 and libvips to v8.5.6

* fix(Docker): use proper SHA256 hash

* fix(server_test): assert content type header is present

* feat(History): add missing Docker changes

* Update README.md (h2non#143)

Small typo.

* Typos and minor language in help text (h2non#144)

* fix(h2non#146): handle proper response code range for max allowed size

* feat(version): bump to v1.0.2

* feat(docs): update maintainer note

* Adding the Gaussian Blur feature plus a few minor formatting with gofmt. (h2non#150)

* Adding the Gaussian Blur feature plus a few minor formatting changes with gofmt.

* Adding the Gaussian Blur to the BimgOptions instantiation method

* Adding the Gaussian Blur to the BimgOptions instantiation method - More documentation added

* fix(docs): CLI spec typo

* feat(version): bump to v1.0.3

* Mapping Blur URL params to the ImageOptions struct fields (h2non#152)

* feat(version): bump to 1.0.4

* feat(params): add stripmeta params

* feat(History): update version changes

* feat(version): bump to v1.0.5

* feat(version): bump to v1.0.6

* feat(version): bump to v1.0.7

* refactor(license): update copyright

* feat(docs): add sponsor ad

* refactor(docs): move sponsor banner

* feat(h2non#101): add pipeline endpoint implementation + smart crop (h2non#154)

* feat(h2non#101): add pipeline endpoint implementation + smart crop

* refactor(docs): update internal docs links

* refactor(docs): update author notes

* fix(tests): refactor Options -> Params

* feat(docs): add note about pipeline max operations

* feat(version): v1.0.8

* feat(docs): add note about Docker and Heroku

* feat(docs): add imagelayer badge

* feat(docs): add imagelayer badge

* feat(docs): add imagelayer badge

* feat(docs): add imagelayer badge

* refactor(docs): specify POST payloads in description

* feat(travis): add Go 1.9 support

* feat(vendor): add vendor dependencies

* refactor(Gopkg): define version

* feat(vendor): support dependencies vendoring

* refactor(requirements): add Go 1.6+ as minimum requirement

* refactor(Dockerfile): use local source copy

* debug(travis)

* debug(travis)

* debug(travis)

* debug(travis)

* debug(travis)

* fix(h2non#157): disable gzip compression support

* feat(version): bump to v1.0.9

* feat(h2non#156): support disable endpoints (h2non#160)

* feat(h2non#156): support disable endpoints

* fix(docs): remove no-form docs

* feat(bimg): upgrade to v1.0.16

* feat(version): bump to v1.0.10

* feat(Dockerfile): upgrade to Go 1.9.2

* feat(docs): update CLI usage help

* Add /fit action

* Add type=auto using client Accept header to auto negotiate type. (h2non#162)

* Add type=auto using client Accept header to auto negotiate type.

* Review feedback

* fix(test): remove unused variable body

* refactor(image): remove else statement

* feat(bimg): update to v1.0.17

* feat(version): bump to v1.0.11

* fix(type_test): use string for proper formatting

* refactor(docs): update CLI usage and minimum requirements

* Log hours in 24 hour clock (h2non#165)

* fix testdata image links (h2non#173)

* refactor(docs): remove codesponsor :(

* refactor(vendor): remove go-debug package from vendor

* feat: add docker-compose.yml

* fix(debug): implement custom debug function

* feat(vendor): upgrade bimg to v1.0.18

* feat(Docker): upgrade libvips to v8.6.2 (h2non#184)

* feat(Docker): upgrade libvips to v8.6.2

* feat(travis): add libvips v8.6 & Go v1.10 runtime environments

* feat(version): bump to v1.0.13

* feat(history): update changelog

* fix(Dockerfile): update version sha2 hash

* Fixes https by installing root CA certificates (h2non#186)

* Add Docker Compose note to README (h2non#174)

* add docker-compose.yml note

* feat(docs): add docker-compose.yml example

* feat(version): bump to v1.0.14

* Changing build steps (h2non#189)

* feat(version): bump to v1.0.15

* fix(docker): remove race detector (h2non#197)

* Add URL signature feature (h2non#194)

* Add URL signature feature

* Fix signature salt empty & key/salt check

* Drop salt as suggested in h2non#194 (h2non#200)

* Fix typo in documentation (h2non#202)

* Update README.md (h2non#207)

* Update README.md

Updates link in table of contents

* Update README.md

* Add new param aspect ratio

* return nil if aspect ratio is not parsable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants