Fix cmake for OpenSSL 1.0.2a

[evmuc]

Hi there,

is it possible to fix the FindOpenSSL routine in cmake for supporting OpenSSL 1.0.2a?

http://www.cmake.org/gitweb?p=cmake.git;a=commitdiff;h=c5d9a8283cfac15b4a5a07f18d5eb10c1f388505

Would be perfect ....

[kazuho]

Thank you for the suggestion.

How did you specify the path to openssl? I suspect that a workaround could be to use PKG_CONFIG_PATH, e.g. PKG_CONFIG_PATH=/usr/local/openssl-1.0.2a/lib/pkgconfig cmake ..

The reason I prefer to ask using an workaround is because generally speaking I would not want to maintain a copy of a cmake module by myself.

[kazuho]

Tried myself, and confirmed that by specifying PKG_CONFIG_PATH it is possible to build using OpenSSL 1.0.2a. Below are the log of the cmake command for cmake version 3.1.0 and 2.8.12.

$ PKG_CONFIG_PATH=/usr/local/openssl-1.0.2/lib/pkgconfig /usr/local/cmake-3.1.0/bin/cmake ../..
-- The C compiler identification is AppleClang 6.0.0.6000056
-- The CXX compiler identification is AppleClang 6.0.0.6000056
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++
-- Check for working CXX compiler: /usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Found PkgConfig: /usr/local/bin/pkg-config (found version "0.28") 
-- Looking for include file pthread.h
-- Looking for include file pthread.h - found
-- Looking for pthread_create
-- Looking for pthread_create - found
-- Found Threads: TRUE  
-- Found OpenSSL: /usr/local/openssl-1.0.2/lib/libssl.a;/usr/local/openssl-1.0.2/lib/libcrypto.a (found version "1.0.2a") 
-- checking for module 'libuv>=1.0.0'
--   found libuv, version 1.0.0
-- checking for module 'libwslay'
--   found libwslay, version 0.1.1
-- Configuring done
-- Generating done
-- Build files have been written to: /mydev/h2o/build/osx

$ PKG_CONFIG_PATH=/usr/local/openssl-1.0.2/lib/pkgconfig cmake ../..
-- The C compiler identification is Clang 6.0.0
-- The CXX compiler identification is Clang 6.0.0
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++
-- Check for working CXX compiler: /usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Found PkgConfig: /usr/local/bin/pkg-config (found version "0.28") 
-- Looking for include file pthread.h
-- Looking for include file pthread.h - found
-- Looking for pthread_create
-- Looking for pthread_create - found
-- Found Threads: TRUE  
-- Found OpenSSL: /usr/local/openssl-1.0.2/lib/libssl.a;/usr/local/openssl-1.0.2/lib/libcrypto.a (found version "1.0.2a") 
-- checking for module 'libuv>=1.0.0'
--   found libuv, version 1.0.0
-- checking for module 'libwslay'
--   found libwslay, version 0.1.1
-- Configuring done
-- Generating done
-- Build files have been written to: /mydev/h2o/build/osx

Also confirmed that if cmake (both 2.8.12 and 3.1.0) fails to detect OpenSSL if I set OPENSSL_ROOT_DIR=/usr/local/openssl-1.0.2 instead of PKG_CONFIG_PATH.