Join GitHub today
[WIP] reverse proxy add headers support. #1126
This pull request is for supporting add custom constant headers when sending request to application server as a reverse proxy. Currently only proxy.header.add is supported. Since lib/headers.c is a filter, we cannot directly reuse the existed implementation. To show how I think this feature should be implemented, this pull request now has some copy & paste codes which should be eliminated. Waiting for advice.
Thank you for the PR, sorry for the belated response.
Regarding code-reuse, how about taking the following approach? The basic idea is not store common code in util.c, while retaining the distinction between the core library and the configurators.
Thank you for the updates.
I've left my ideas. Please let me know what you think (or make changes if my comments make sense to you).
Thank you in advance.
Jan 19, 2017
1 check passed
added a commit
this pull request
Jan 19, 2017
@zlm2012 Sorry it took so long. The branch has now been merged to master. Thank you for your work and for your patience.
I would appreciate it if you could look into adding docs as well as adding an end-to-end test (e.g. create t/50reverse-proxy-tweak-headers.t), when you have time.