stop removing session cache from memcached #1185
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as discussed at #1087 (comment), we shouldn't remove tls session cache actively.
Regarding the manual, there are 3 triggers the remove callback gets called:
For the first one, currently we're using memcached (and redis in near future) which have their own expiration feature, so there's no need to remove explicitly.
For the second, we would not want to remove a cache entry when a connection is abruptly shut down, which is often the case with the browsers.
For the last, the session cache should also still be alive.
For above reasons, I believe that we should do nothing when the remove events get fired