non-temporal aes-gcm engine#384
Merged
Merged
Conversation
Merged
huitema
reviewed
May 1, 2022
huitema
left a comment
Collaborator
There was a problem hiding this comment.
Maybe split this PR in two? First, do the API changes in struct st_ptls_aead_context_t, including the changes in the bcrypt library, and then, add the support for fastls?
Member
Author
Right. I opened the PRs in the wrong order, but #385 is supposed to do that. |
…(revert prev commit) This reverts commit 86aa4f6.
…de union. It's annoying, but using separate types makes the code safer
…ul, as that causes spills. Works better for encrypt_v128
… for xor as well as retaining 96-bytes of encrypted bytes) was better but GCC can no longer reorder much
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements "non-temporal aes-gcm" engine, that uses non-temporal store instructions when emitting encrypted bytes.
ToDo:
Builds on top of #385.
Older result: as of e0caecc, aes128gcm (16KB block) throughput, compared to openssl (ubuntu 20.04):
*: "nt off" indicates that non-temporal store instructions (
_mm_stream_si256) were replaced by ordinary stores (_mm_store_si256).