Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
hoist boundary check code to the out of loop #10
Current implementation of sprintf(..., "%x",...) always execute boundary check.
This pull request hoists this check to the out of loop to simplify main code of hexadecimal to string conversion.
Thank you for the PR.
I agree that boundary check should not be performed for every byte, I am basically fine to merge the changes. Before that, would you mind making following changes so that the diff would be minimal?
It would be great if you could make such changes so that the diff of gets limited to the topic of the branch (i.e. only change the
I would appreciate it if you could either open a separate PR or a separate commit within this PR to change other things in case you are convinced that my understanding described in the above listing is wrong.
Thank you for your comment.
But we cannot modify the code as above because it breaks a compatibility with