Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Parameter na_strings for fread #95

Closed
st-pasha opened this issue Jun 28, 2017 · 0 comments · Fixed by #96
Closed

Implement Parameter na_strings for fread #95

st-pasha opened this issue Jun 28, 2017 · 0 comments · Fixed by #96
Labels
fread Issues related to parsing any input files via fread function improve Improvement of an existing functionality
Milestone
Olden times

Comments

@st-pasha
Copy link
Contributor

If the parameter is not given, it should default to ["NA"].
If the parameter is given, we need to make sure that it actually works.
@st-pasha st-pasha added improve Improvement of an existing functionality fread Issues related to parsing any input files via fread function labels Jun 28, 2017
@st-pasha st-pasha mentioned this issue Jun 28, 2017
Closed
18 tasks
st-pasha added a commit that referenced this issue Jun 28, 2017
@st-pasha
Add default setting for na_strings parameter. Closes #95
48112ad
@st-pasha st-pasha mentioned this issue Jun 28, 2017
Merged
st-pasha added a commit that referenced this issue Jun 28, 2017
@st-pasha
Make na_strings parameter for fread actually work (#96)
4da18e0 
* Fix bug with TOSTRINGLIST macro (it used buffers which could have become deallocated)
* Add default setting for na_strings parameter. 
* Closes #95
@st-pasha st-pasha added this to the Olden times milestone Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fread Issues related to parsing any input files via fread function improve Improvement of an existing functionality
Projects
None yet
Milestone
Olden times
Development

Successfully merging a pull request may close this issue.

Make na_strings parameter for fread actually work h2oai/datatable
1 participant
@st-pasha