Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] probability calibration does not work in Sparkling Water Dataframe API #1108

Closed
goldminer09 opened this issue Mar 26, 2019 · 3 comments
Closed

Comments

@goldminer09
Copy link

@goldminer09 goldminer09 commented Mar 26, 2019

Although when calibration is enabled, EasyPredictModelWrapper returns a BinomialModelPrediction object which contains both raw probs and calibrated probs, the
implicit conversion defined here

implicit def toBinomialPrediction(pred: AbstractPrediction) = BinomialPrediction(
pred.asInstanceOf[BinomialModelPrediction].classProbabilities(0),
pred.asInstanceOf[BinomialModelPrediction].classProbabilities(1))
transforms the BinomialModelPrediction object to a BinomialPrediction, which only contains raw probs (p0, and p1) and calibrated probabilities are NOT returned. Both raw and calibrated probabilities should be returned to the user.

@jakubhava

This comment has been minimized.

Copy link
Contributor

@jakubhava jakubhava commented Apr 2, 2019

Hi @goldminer09, thanks, this is a good point!

Could you give it a try and implement the fix? Thanks!

@laurendiperna

This comment has been minimized.

Copy link

@laurendiperna laurendiperna commented Apr 26, 2019

@goldminer09 I made your github issue into a JIRA Ticket so we can start tracking it. Please feel free to update the ticket if needed here. Thanks!

@jakubhava

This comment has been minimized.

Copy link
Contributor

@jakubhava jakubhava commented May 1, 2019

Closing this issue as we have JIRA. Currently testing the solution, if all good, will go to the next release. Please use the JIRA to track the progress

@jakubhava jakubhava closed this May 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.