From 657d6da8a8ecb3729f1ffdcca8f4bd22aee37eb4 Mon Sep 17 00:00:00 2001 From: MattiasOz Date: Fri, 29 Sep 2023 15:41:04 +0200 Subject: [PATCH 1/3] feat: removed reserved space for empty titles in vega_card #1923 --- ui/src/vega.tsx | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/ui/src/vega.tsx b/ui/src/vega.tsx index be2303c900..f91842d62b 100644 --- a/ui/src/vega.tsx +++ b/ui/src/vega.tsx @@ -147,10 +147,15 @@ export const const { specification, data, title, grammar = 'vega-lite' } = state return (
-
{title}
+ {title &&
{title}
} + {title &&
-
+
} + {!title && +
+ +
} ) } From 553b9d77bd0de6e4d4c61b97acde025c41c408fd Mon Sep 17 00:00:00 2001 From: MattiasOz Date: Mon, 2 Oct 2023 14:09:36 +0200 Subject: [PATCH 2/3] feat: removed reserved space for empty titles in vega_card, simplified #1923 --- ui/src/vega.tsx | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/ui/src/vega.tsx b/ui/src/vega.tsx index f91842d62b..f06e5b7915 100644 --- a/ui/src/vega.tsx +++ b/ui/src/vega.tsx @@ -28,7 +28,6 @@ const padding: 24 }, body: { - marginTop: 16, flexGrow: 1, display: 'flex', }, @@ -148,14 +147,9 @@ export const return (
{title &&
{title}
} - {title &&
-
} - {!title && -
- -
} +
) } From 5d533923a6f4c50d6f3ed5222e68a7e0c6bf7d7b Mon Sep 17 00:00:00 2001 From: MattiasOz Date: Mon, 2 Oct 2023 15:50:59 +0200 Subject: [PATCH 3/3] feat: removed reserved space for empty titles in vega_card, version_3 #1923 --- ui/src/vega.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/src/vega.tsx b/ui/src/vega.tsx index f06e5b7915..ad5dfb16fd 100644 --- a/ui/src/vega.tsx +++ b/ui/src/vega.tsx @@ -146,7 +146,7 @@ export const const { specification, data, title, grammar = 'vega-lite' } = state return (
- {title &&
{title}
} + {title &&
{title}
}