Google Cache snapshot Issue #1086

Closed
foodgy opened this Issue May 9, 2012 · 14 comments

Projects

None yet

7 participants

@foodgy
foodgy commented May 9, 2012

Noticed a strange bug with Google cache and h5bp.
Look at this http://webcache.googleusercontent.com/search?hl=en&q=cache%3Ahttp%3A%2F%2Fhtml5boilerplate.com%2F

There is no page snapshot. Only text version.
I have 2 more sites based on h5bp 3.0.2 with the same bug.

@drublic
Member
drublic commented May 9, 2012

Thank you for reporting this issue, @foodgy.
We've found out that this has something to do with the conditional comments for the html-tag. You can see this if you take a look at for example my blog on Google Cache which uses HTML5 Boilerplate but not the CC for the html-tag.
I'll try to investigate a little bit more on this. Not sure how to test though… It seems like a bug in Google Cache.
Maybe there is a way to work around this.

Please let me know if you find out anything.

@paulirish
Member

can people try a few more h5bp-based sites? http://html5boilerplate.tumblr.com/ has a big list of 'em, fwiw.

If we can isolate anything else, I'd be quite happy to file an internet ticket on whatever that snapshot tool is.

@paulirish
Member

things are fine when javascript is disabled.
could be something within modernizr or html5shiv that is wiping out the document.body ?

@foodgy
foodgy commented May 9, 2012

Maybe problem is in modernzr 2.5.3?

http://erpfans.co.uk/ - no Google Cache snapshot. Modernzr 2.5.3
http://www.dishonored.com/ - OK with modernzr 1.7
http://ot.nixon.com/ - OK with modernzr 2.0.6
http://www.itv.com/news/ - no Google Cache snapshot. Modernzr 2.5.3
http://kb24.com - OK with modernzr 2.0.6
http://coolvillage.es/en - OK with modernzr 2.0.6
http://html5boilerplate.com/ - no Google Cache snapshot. Modernzr 2.5.3
http://a-class.mercedes-benz.com/com/en/ - no Google Cache snapshot. Modernzr 2.5.3

@paulirish
Member

cc @afarkas :)

@aFarkas
aFarkas commented May 9, 2012

Yes, this issue comes from Modernizr 2.5.3. But, it's already fixed by @ryanseddon, so everything should be fine with next version.

@drublic
You can use fiddler or charles to debug those things really easily. I'm a big fan of those tools. Here is a short documentation of the most usefull feature

@foodgy
foodgy commented May 10, 2012

Nice! When will we get next modernizr stable release? ;)

@mathiasbynens
Member

According to the commit message and the relevant issue, Modernizr/Modernizr@c9828ee only addresses IE bugs. @afarkas, what makes you so sure this also fixes the problem described here? Could you provide some more details, please?

@aFarkas
aFarkas commented May 13, 2012

@mathiasbynens

Sorry for the delay. I have simply used fiddler's autoresponder to change the resources for Modernizr. In general I did the following:

  1. respond Modernizr with an empty file -> bug was fixed (conclusion: bug is caused by Modernizr)
  2. respond with the 2.5.3 tagged version from the Modernizr repo -> bug exists (conclusion: bug can be reproduced with the uncompressed github source)
  3. respond with the newest dev version of Modernizr -> bug doesn't exisit anymore (conclusion: bug was fixed somewhere)
  4. going up the commits starting with the newest commit after tag 2.5.3 -> bug doesn't exist anymore (conclusion: this commit has also fixed this issue)
@necolas
Member
necolas commented May 28, 2012

We'll keep this open and hold back on a new release of H5BP until there is a new stable release of Modernizr.

@necolas
Member
necolas commented Jul 7, 2012

Any update on when Modernizr will get a new release out with this patch?

@drublic
Member
drublic commented Jul 8, 2012

Modernizr/Modernizr#560 has a roadmap for Modernizr.next. @paulirish states that this version should already be shipped but Modernizr/Modernizr#619 seems to be a blocker.
I guess it's just a matter of days until the 2.6 release will be available.

Would be great to get feedback from the Modernizr team :)
/cc: @SlexAxton

@SlexAxton

The addTest addition is the easy part. The hard part is breaking everything into modules. We still have some work to do on that front.

@necolas
Member
necolas commented Jul 8, 2012

Ok thanks. Closing as this is a Modernizr bug.

@necolas necolas closed this Jul 8, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment