Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New image replacement approach shows selection highlight #1239

Closed
paulsham opened this issue Oct 22, 2012 · 3 comments

Comments

Projects
None yet
3 participants
@paulsham
Copy link

commented Oct 22, 2012

Using the new image replacement method (Commit adecc5d) creates an issue when highlighting over an image replaced element (using .ir) results in a thin line from the selection highlight appearing at the bottom of the element. This does depend on the line-height and font-family of the replaced text.

My simple fix was to add a larger line-height to push the selection highlight further down.

Viewable in Firefox 16.0.1 Mac.
Live example: http://jsfiddle.net/paulsham/g2enP/4/

@drublic

This comment has been minimized.

Copy link
Member

commented Nov 23, 2012

I can reproduce this. Thank you for reporting!

We could fix this with defining a line-height for .ir. Currently in your test this can be fixed with a line-height of 1.2 on .ir but this might be dependent on the font-family, font-size, initial line height aso. So there need to be a lot of tests.

Seems like a minor issue to me and I'm not sure if we should include a fix since testing that stuff would need lot of time without a lot of effect on the user's experience.

What do you think?

@paulsham

This comment has been minimized.

Copy link
Author

commented Nov 26, 2012

It is a minor issue, so no rush.
I did try messing around with the user-select CSS, but that doesn't seem to work.

@necolas necolas closed this in 081f8aa Dec 28, 2012

@necolas

This comment has been minimized.

Copy link
Member

commented Dec 28, 2012

Thanks. Should be fixed now. Just bumped up the height of the pseudo-element that doesn't the offscreen-pushing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.