New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

miketaylr's feedback #2

Closed
paulirish opened this Issue Jan 24, 2010 · 1 comment

Comments

Projects
None yet
1 participant
@paulirish
Member

paulirish commented Jan 24, 2010

Notes on Paul Irish's starter template.

Mike Taylor
11/08/2009

  • meta name=keywords? I'm no SEO wizard, but I tend to still use this guy in conjunction with meta name=description.
  • using HTML5 doctype and a html5 shiv script for IE, yet <div id=header>, <div id=footer>.
    Why not <header> & <footer>? Although I can understand if you don't want to force people to go server-side to fix FF2.
  • How is<html lang=en> different from <meta http-equiv="content-language" content="en">? There might be something I'm not aware of here.
  • In html5, <script type> defaults to text/javascript if not present. So, you can leave it out if you want to live in the future. I don't know if there are any real-world consequences to doing so today.

http://www.whatwg.org/specs/web-apps/current-work/#script
'(The default, which is used if the attribute is absent, is "text/javascript".)'

  • Remy's html5 enabling script is a little out of date--<dialog> is no longer in the spec, nor is <eventsource>. (There are naturally more new elements in the spec, but I can't imagine you'd try to style a element, for example.)
  • In script.js small typo:

//common domready code => common domready code

  • In script.js FOO.config and FOO.strings could use some simple explanatory comments to explain why they're in there.
  • In reset.css:
    • dialog can be removed from lines 21 and 36.
    • Line 32 of the html5 reset stylesheet (body{line-height:1} is essentially getting overwritten by line 109 (yui's body * {line-height:1.22em}, right? Or would there be some meaningful reason to have body at 1 but all of body's descendants at 1.22em? If not, 32 could be removed.
    • Shouldn't line 121 also include .ie6? i.e., .ie6 img, .ie7 img {-ms-interpol...;}
    • A few missing ending semi-colons: line 129, 140, 151, 152
    • If you were crazy like i am, you could change line 144 -> color: #003366 -> color: #36.
@paulirish

This comment has been minimized.

Show comment
Hide comment
@paulirish

paulirish May 20, 2010

Member

index.html cleanup. addresses miketaylr's old concerns. closed by 1988165

Member

paulirish commented May 20, 2010

index.html cleanup. addresses miketaylr's old concerns. closed by 1988165

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment