rip hot pink in 404.html #1067

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
4 participants
Contributor

elexx commented Apr 23, 2012

changed the text selection color in 404.html
(maybe 404.html should load style.css instead of define css inline?)

@elexx elexx rip hot pink in 404.html
changed the text selection color in 404.html
maybe 404.html should load style.css instead of define css inline?
c1843fa
Owner

drublic commented Apr 23, 2012

Could you please remove the color-property, too? It would then be the same as in the styles.css. Thanks!

I don't think including styles.css in the 404.html-file is necessary as it adds a lot of stuff you don't need. Besides that, the 404-file needs some extra styling.

Contributor

elexx commented Apr 23, 2012

done.

on the other hand including the css would prevent any further pull requests like this :-)

Contributor

mikealmond commented Apr 23, 2012

I think the boilerplate should keep the hot pink on the 404 page.

+

drublic closed this in a95f300 Apr 23, 2012

Owner

drublic commented Apr 23, 2012

@elexx, thanks for reporting this. I've combined the PR into one commit and pushed this.

@mikealmond This is a nice idea. I don't think we should have two different colors though.
Other opinions on this?

@StilgarBF StilgarBF added a commit to StilgarBF/html5-boilerplate that referenced this pull request Apr 23, 2012

@drublic @StilgarBF drublic + StilgarBF Change selection-color in 404 error template, closes #1067
The selection-color was changed in 1d320b5. Add this background-color in the 404 error template and remove the text-color. Thanks to @elexx.
902c372
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment