Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

rip hot pink in 404.html #1067

Closed
wants to merge 2 commits into from

4 participants

@elexx

changed the text selection color in 404.html
(maybe 404.html should load style.css instead of define css inline?)

@elexx elexx rip hot pink in 404.html
changed the text selection color in 404.html
maybe 404.html should load style.css instead of define css inline?
c1843fa
@drublic
Owner

Could you please remove the color-property, too? It would then be the same as in the styles.css. Thanks!

I don't think including styles.css in the 404.html-file is necessary as it adds a lot of stuff you don't need. Besides that, the 404-file needs some extra styling.

@elexx

done.

on the other hand including the css would prevent any further pull requests like this :-)

@mikealmond

I think the boilerplate should keep the hot pink on the 404 page.

@drublic drublic closed this pull request from a commit
@drublic drublic Change selection-color in 404 error template, closes #1067
The selection-color was changed in 1d320b5. Add this background-color in the 404 error template and remove the text-color. Thanks to @elexx.
a95f300
@drublic drublic closed this in a95f300
@drublic
Owner

@elexx, thanks for reporting this. I've combined the PR into one commit and pushed this.

@mikealmond This is a nice idea. I don't think we should have two different colors though.
Other opinions on this?

@StilgarBF StilgarBF referenced this pull request from a commit in StilgarBF/html5-boilerplate
@drublic drublic Change selection-color in 404 error template, closes #1067
The selection-color was changed in 1d320b5. Add this background-color in the 404 error template and remove the text-color. Thanks to @elexx.
902c372
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Apr 23, 2012
  1. @elexx

    rip hot pink in 404.html

    elexx authored
    changed the text selection color in 404.html
    maybe 404.html should load style.css instead of define css inline?
  2. @elexx

    removed the color property.

    elexx authored
This page is out of date. Refresh to see the latest.
Showing with 2 additions and 2 deletions.
  1. +2 −2 404.html
View
4 404.html
@@ -4,8 +4,8 @@
<meta charset="utf-8">
<title>Page Not Found :(</title>
<style>
- ::-moz-selection { background: #fe57a1; color: #fff; text-shadow: none; }
- ::selection { background: #fe57a1; color: #fff; text-shadow: none; }
+ ::-moz-selection { background: #b3d4fc; text-shadow: none; }
+ ::selection { background: #b3d4fc; text-shadow: none; }
html { padding: 30px 10px; font-size: 20px; line-height: 1.4; color: #737373; background: #f0f0f0; -webkit-text-size-adjust: 100%; -ms-text-size-adjust: 100%; }
html, input { font-family: "Helvetica Neue", Helvetica, Arial, sans-serif; }
body { max-width: 500px; _width: 500px; padding: 30px 20px 50px; border: 1px solid #b3b3b3; border-radius: 4px; margin: 0 auto; box-shadow: 0 1px 10px #a7a7a7, inset 0 1px 0 #fff; background: #fcfcfc; }
Something went wrong with that request. Please try again.