Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated BrowseHappy prompt to be site-agnostic #1608

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
7 participants
@alilleybrinker
Copy link
Contributor

commented Sep 29, 2014

Per the discussion in #1582, this simply replaces all explicit references to BrowseHappy with more site-agnostic wording.

@@ -15,7 +15,7 @@
</head>
<body>
<!--[if lt IE 8]>
<p class="browsehappy">You are using an <strong>outdated</strong> browser. Please <a href="http://browsehappy.com/">upgrade your browser</a> to improve your experience.</p>
<p class="browserupgrade">You are using an <strong>outdated</strong> browser. Please <a href="http://browsehappy.com/">upgrade your browser</a> to improve your experience.</p>

This comment has been minimized.

Copy link
@frenzzy

frenzzy Sep 30, 2014

Contributor

How about to change url from http://browsehappy.com/ to http://outdatedbrowser.com ?

This comment has been minimized.

Copy link
@drublic

drublic Sep 30, 2014

Member

Seems to be a good idea imo. Outdated Browser is also available in multiple languages.

This comment has been minimized.

Copy link
@FagnerMartinsBrack

FagnerMartinsBrack Sep 30, 2014

Contributor

This and #1582 are related, but with different purposes.

This comment has been minimized.

Copy link
@alilleybrinker

alilleybrinker Sep 30, 2014

Author Contributor

This change goes hand-in-hand with the changes being discussed in #1582, but doesn't depend on them (that is, the change is useful regardless of whether the URL is changed). I am happy to change the URL here if everyone thinks it's best, but given that there is already a PR discussing it making that change here may be premature.

This comment has been minimized.

Copy link
@FagnerMartinsBrack

FagnerMartinsBrack Sep 30, 2014

Contributor

I suggest keeping PRs atomic, makes it much more understandable for watchers.

This comment has been minimized.

Copy link
@alrra

alrra Sep 30, 2014

Member

@frenzzy, @drublic Like @FagnerMartinsBrack said, let's keep the two separate, and discuss to which site we link to in #1582 (because IMHO, there are issues with both sites).

@alrra

This comment has been minimized.

Copy link
Member

commented Sep 30, 2014

Is everyone ok with this browserupgrade classname? Are there any other suggestions for the classname?

@battaglr

This comment has been minimized.

Copy link
Contributor

commented Oct 1, 2014

Maybe browser-upgrade to increase readability? Anyhow, making this site-agnostic is already a great idea.

@FagnerMartinsBrack

This comment has been minimized.

Copy link
Contributor

commented Oct 1, 2014

@battaglr That would not be consistent with how h5bp currently handles class names here

@arthurvr

This comment has been minimized.

Copy link
Member

commented Oct 1, 2014

I'm fine with the browserupgrade classname. I personally think it's readable enough, and also, it's more consistent with classnames in h5bp.

@battaglr

This comment has been minimized.

Copy link
Contributor

commented Oct 1, 2014

@FagnerMartinsBrack: oops! You're right. :)

In that case browserupgrade sounds great. 👍

@alrra alrra closed this in d5e0625 Oct 6, 2014

@alrra alrra removed the awaiting feedback label Oct 6, 2014

@alilleybrinker alilleybrinker deleted the alilleybrinker:browser-upgrade-agnostic branch Oct 6, 2014

eleanor-byhook pushed a commit to eleanor-byhook/html5-boilerplate that referenced this pull request Feb 29, 2016

Change the outdated browser prompt classname
While the outdated browser prompt currently links to `browsehappy.com`,
users are free and even encouraged to substitute the link with their own
page or site of preference.

This commit changes the `browsehappy` specific classname with the more
agnostic `browserupgrade` in order to make the link substitution
easier, but more importantly to hint to the users that they don't have
to stick with the currently default provided `browsehappy.com` link.

Ref: h5bp/html5-boilerplate#1582
     h5bp/html5-boilerplate#1608

Close h5bp/html5-boilerplate#1608

jeffreznik pushed a commit to jeffreznik/sw-test that referenced this pull request Oct 15, 2017

Change the outdated browser prompt classname
While the outdated browser prompt currently links to `browsehappy.com`,
users are free and even encouraged to substitute the link with their own
page or site of preference.

This commit changes the `browsehappy` specific classname with the more
agnostic `browserupgrade` in order to make the link substitution
easier, but more importantly to hint to the users that they don't have
to stick with the currently default provided `browsehappy.com` link.

Ref: h5bp#1582
     h5bp#1608

Close h5bp#1608
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.