New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v7.0 Docs Update #2074

Merged
merged 5 commits into from Feb 7, 2019

Conversation

Projects
None yet
3 participants
@coliff
Copy link
Member

coliff commented Oct 4, 2018

  • Remove unneeded x-ua-compatible - not needed for IE11
  • Update many external links
  • Fix typos
  • Add info for creating a good meta description
  • Add link for iPhone X viewport info
  • Update browser upgrade prompt
  • Remove integrating Bootstrap with H5BP (it was written a longtime ago and I don't think is relevant so much)
  • Remove statement that Twitter Cards requires registering a domain (its now open for all sites)
  • Remove official shortlink section, it was always very poorly supported
  • Made the touch icons sections more concise (no need to mention about non-retina iPhones and iOS versions prior to iOS 6 etc)
  • Add <meta name="theme-color" content="#fafafa"> to index.html
  • Add details on security.txt in extend docs

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Pull requests should be thought of as a conversation. There will be some back and forth when trying to get code merged into this or any other project. With all but the simplest changes you can and should expect that the maintainers of the project will request changes to your code. Please be aware of that and check in after you open your PR in order to get your code merged in cleanly.

Thanks!

coliff added some commits Oct 4, 2018

v7.0 (WIP)
- Remove unneeded x-ua-compatible - not needed for IE11
- Update many external links
- Fix typos
- Add info for creating a good meta description
- Add link for iPhone X viewport info
- Update browser upgrade prompt
- Remove integrating Bootstrap with H5BP (it was written a longtime ago and I don't think is relevant so much)
- Remove statement that Twitter Cards requires registering a domain
- Remove official shortlink section, it was always very poorly supported
- Made the touch icons sections more consise (no need at all to mention about non-retina iPhones and iOS versions prior to iOS 6 etc)
update README to links to previous versions
- update package,json deps

@coliff coliff added this to the 7.0 milestone Oct 4, 2018

@coliff coliff referenced this pull request Oct 9, 2018

Closed

Ship v7.0 #2076

10 of 10 tasks complete
@Suneet-M

This comment has been minimized.

Copy link

Suneet-M commented Nov 24, 2018

Hey, you need any help? Want to get some open source experience, pretty new here.

@@ -620,19 +586,14 @@ Icons](https://mathiasbynens.be/notes/touch-icons).

Apart from that it is possible to add start-up screens for web apps on iOS. This
basically works by defining `apple-touch-startup-image` with an according link
to the image. Since iOS devices have different screen resolutions it is
to the image. Since iOS devices have different screen resolutions it maybe

This comment has been minimized.

@roblarsen

roblarsen Feb 6, 2019

Member

may be

@@ -620,19 +586,14 @@ Icons](https://mathiasbynens.be/notes/touch-icons).

Apart from that it is possible to add start-up screens for web apps on iOS. This
basically works by defining `apple-touch-startup-image` with an according link
to the image. Since iOS devices have different screen resolutions it is
to the image. Since iOS devices have different screen resolutions it maybe

This comment has been minimized.

@roblarsen

roblarsen Feb 6, 2019

Member

where we actually need to make the change

@roblarsen roblarsen changed the title v7.0 Docs Update (WIP) v7.0 Docs Update Feb 6, 2019

@roblarsen

This comment has been minimized.

Copy link
Member

roblarsen commented Feb 6, 2019

going once... going twice...

🔨

@roblarsen roblarsen merged commit bbe9e8a into master Feb 7, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@coliff coliff deleted the v7.0 branch Feb 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment