Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Option for desktop browsers only #66

Closed
akavlie opened this Issue · 6 comments

3 participants

Aaron Kavlie Hans Christian Reinl Addy Osmani
Aaron Kavlie

The API lists iOS Safari among the suggested browsers. This doesn't look right to me, if the goal is to give the user links to browsers they can upgrade to.

There should be an option to limit results to desktop browsers only.

Hans Christian Reinl
Owner

This is totally right. The API is supposed to list only browsers that are supported on a specific OS. For instance we don't want to suggest IE if you're on a Mac.

It would be great if you could provide a short test-case for this issue.
Thank you!

Aaron Kavlie

I could take a stab at that... assuming you've done dev work on this, could you point me in the right direction? Is there already code for selecting browser links based on OS?

I'm not sure there's any situation where iOS Safari would be relevant -- it can't be installed on its own. Info about minimum OS version would make more sense on mobile.

Hans Christian Reinl
Owner

The OS should be detected automatically by the API. You don't need set a param for this.
I've created a test-case which reproduces this issue. On Chrome only Opera Mobile is offered as an alternative the "stream".

I'll try to figure out what the problem is in the next days.

Addy Osmani

@drublic do you think you might have the bandwidth to chase this up?

Hans Christian Reinl drublic referenced this issue from a commit
Hans Christian Reinl drublic Filter partial-supported browser by type
as described in #66
71567c7
Hans Christian Reinl
Owner

@addyosmani, thanks for the reminder. And sorry, for the missing update.

This problem is now fixed with the last commit I. When implementing the "partial"-support I forgot to filter the results by the type of the OS. I've now implemented it (was just 1 LoC).
Please let me know if there are further problems with detecting the type.

Hans Christian Reinl drublic closed this
Addy Osmani

@drublic Perfect. Thank you for working on this so quickly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.