Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Option for desktop browsers only #66

akavlie opened this Issue May 8, 2012 · 6 comments


None yet
3 participants

akavlie commented May 8, 2012

The API lists iOS Safari among the suggested browsers. This doesn't look right to me, if the goal is to give the user links to browsers they can upgrade to.

There should be an option to limit results to desktop browsers only.


drublic commented May 13, 2012

This is totally right. The API is supposed to list only browsers that are supported on a specific OS. For instance we don't want to suggest IE if you're on a Mac.

It would be great if you could provide a short test-case for this issue.
Thank you!

akavlie commented May 13, 2012

I could take a stab at that... assuming you've done dev work on this, could you point me in the right direction? Is there already code for selecting browser links based on OS?

I'm not sure there's any situation where iOS Safari would be relevant -- it can't be installed on its own. Info about minimum OS version would make more sense on mobile.


drublic commented May 14, 2012

The OS should be detected automatically by the API. You don't need set a param for this.
I've created a test-case which reproduces this issue. On Chrome only Opera Mobile is offered as an alternative the "stream".

I'll try to figure out what the problem is in the next days.

@drublic do you think you might have the bandwidth to chase this up?

@drublic drublic added a commit that referenced this issue Jun 10, 2012

@drublic drublic Filter partial-supported browser by type
as described in #66

drublic commented Jun 10, 2012

@addyosmani, thanks for the reminder. And sorry, for the missing update.

This problem is now fixed with the last commit I. When implementing the "partial"-support I forgot to filter the results by the type of the OS. I've now implemented it (was just 1 LoC).
Please let me know if there are further problems with detecting the type.

@drublic drublic closed this Jun 10, 2012

@drublic Perfect. Thank you for working on this so quickly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment