From 6781311802c6f0e9a161f95132a01bab5ad561d3 Mon Sep 17 00:00:00 2001 From: Rob Larsen Date: Fri, 22 Mar 2019 15:11:30 -0400 Subject: [PATCH 1/2] Create .stylelintrc --- .stylelintrc | 107 +++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 107 insertions(+) create mode 100644 .stylelintrc diff --git a/.stylelintrc b/.stylelintrc new file mode 100644 index 0000000..f2b748b --- /dev/null +++ b/.stylelintrc @@ -0,0 +1,107 @@ + { + "extends": "stylelint-config-recommended", + "rules": { + "at-rule-empty-line-before": [ "always", { + except: [ + "blockless-after-same-name-blockless", + "first-nested", + ], + ignore: ["after-comment"], + } ], + "at-rule-name-case": "lower", + "at-rule-name-space-after": "always-single-line", + "at-rule-semicolon-newline-after": "always", + "block-closing-brace-empty-line-before": "never", + "block-closing-brace-newline-after": "always", + "block-closing-brace-newline-before": "always-multi-line", + "block-closing-brace-space-before": "always-single-line", + "block-opening-brace-newline-after": "always-multi-line", + "block-opening-brace-space-after": "always-single-line", + "block-opening-brace-space-before": "always", + "color-hex-case": "lower", + "color-hex-length": "short", + "comment-empty-line-before": [ "always", { + except: ["first-nested"], + ignore: ["stylelint-commands"], + } ], + "comment-whitespace-inside": "always", + "custom-property-empty-line-before": [ "always", { + except: [ + "after-custom-property", + "first-nested", + ], + ignore: [ + "after-comment", + "inside-single-line-block", + ], + } ], + "declaration-bang-space-after": "never", + "declaration-bang-space-before": "always", + "declaration-block-semicolon-newline-after": "always-multi-line", + "declaration-block-semicolon-space-after": "always-single-line", + "declaration-block-semicolon-space-before": "never", + "declaration-block-single-line-max-declarations": 1, + "declaration-block-trailing-semicolon": "always", + "declaration-colon-newline-after": "always-multi-line", + "declaration-colon-space-after": "always-single-line", + "declaration-colon-space-before": "never", + "declaration-empty-line-before": [ "always", { + except: [ + "after-declaration", + "first-nested", + ], + ignore: [ + "after-comment", + "inside-single-line-block", + ], + } ], + "function-comma-newline-after": "always-multi-line", + "function-comma-space-after": "always-single-line", + "function-comma-space-before": "never", + "function-max-empty-lines": 0, + "function-name-case": "lower", + "function-parentheses-newline-inside": "always-multi-line", + "function-parentheses-space-inside": "never-single-line", + "function-whitespace-after": "always", + "indentation": 2, + "length-zero-no-unit": true, + "max-empty-lines": 1, + "media-feature-colon-space-after": "always", + "media-feature-colon-space-before": "never", + "media-feature-name-case": "lower", + "media-feature-parentheses-space-inside": "never", + "media-feature-range-operator-space-after": "always", + "media-feature-range-operator-space-before": "always", + "media-query-list-comma-newline-after": "always-multi-line", + "media-query-list-comma-space-after": "always-single-line", + "media-query-list-comma-space-before": "never", + "no-eol-whitespace": true, + "no-missing-end-of-source-newline": true, + "number-leading-zero": "always", + "number-no-trailing-zeros": true, + "property-case": "lower", + "rule-empty-line-before": [ "always-multi-line", { + except: ["first-nested"], + ignore: ["after-comment"], + } ], + "selector-attribute-brackets-space-inside": "never", + "selector-attribute-operator-space-after": "never", + "selector-attribute-operator-space-before": "never", + "selector-combinator-space-after": "always", + "selector-combinator-space-before": "always", + "selector-descendant-combinator-no-non-space": true, + "selector-list-comma-newline-after": "always", + "selector-list-comma-space-before": "never", + "selector-max-empty-lines": 0, + "selector-pseudo-class-case": "lower", + "selector-pseudo-class-parentheses-space-inside": "never", + "selector-pseudo-element-case": "lower", + "selector-pseudo-element-colon-notation": "double", + "selector-type-case": "lower", + "unit-case": "lower", + "value-list-comma-newline-after": "always-multi-line", + "value-list-comma-space-after": "always-single-line", + "value-list-comma-space-before": "never", + "value-list-max-empty-lines": 0, + }, +} From a193835464e6eda20f5cf218cf8ec4eeee96a9db Mon Sep 17 00:00:00 2001 From: Christian Oliff Date: Mon, 25 Mar 2019 09:55:16 +0900 Subject: [PATCH 2/2] - Add `stylelint-config-recommended` to `package.json` - removed unneeded `-webkit-box-shadow: none !important;` from print styles. If it was needed it'd be added by autoprefixer. - removed unneeded rules from `.stylelintrc` --- .stylelintrc | 199 ++++++++++++++++++++++------------------------ dist/_helpers.css | 4 +- dist/_mqs.css | 6 +- dist/_print.css | 1 - dist/main.css | 41 +++------- package.json | 3 +- src/_custom.css | 15 ---- src/_mqs.css | 6 +- src/_print.css | 1 - src/main.css | 11 ++- 10 files changed, 119 insertions(+), 168 deletions(-) diff --git a/.stylelintrc b/.stylelintrc index f2b748b..a7ede95 100644 --- a/.stylelintrc +++ b/.stylelintrc @@ -1,107 +1,96 @@ - { +{ "extends": "stylelint-config-recommended", - "rules": { - "at-rule-empty-line-before": [ "always", { - except: [ - "blockless-after-same-name-blockless", - "first-nested", - ], - ignore: ["after-comment"], - } ], - "at-rule-name-case": "lower", - "at-rule-name-space-after": "always-single-line", - "at-rule-semicolon-newline-after": "always", - "block-closing-brace-empty-line-before": "never", - "block-closing-brace-newline-after": "always", - "block-closing-brace-newline-before": "always-multi-line", - "block-closing-brace-space-before": "always-single-line", - "block-opening-brace-newline-after": "always-multi-line", - "block-opening-brace-space-after": "always-single-line", - "block-opening-brace-space-before": "always", - "color-hex-case": "lower", - "color-hex-length": "short", - "comment-empty-line-before": [ "always", { - except: ["first-nested"], - ignore: ["stylelint-commands"], - } ], - "comment-whitespace-inside": "always", - "custom-property-empty-line-before": [ "always", { - except: [ - "after-custom-property", - "first-nested", - ], - ignore: [ - "after-comment", - "inside-single-line-block", - ], - } ], - "declaration-bang-space-after": "never", - "declaration-bang-space-before": "always", - "declaration-block-semicolon-newline-after": "always-multi-line", - "declaration-block-semicolon-space-after": "always-single-line", - "declaration-block-semicolon-space-before": "never", - "declaration-block-single-line-max-declarations": 1, - "declaration-block-trailing-semicolon": "always", - "declaration-colon-newline-after": "always-multi-line", - "declaration-colon-space-after": "always-single-line", - "declaration-colon-space-before": "never", - "declaration-empty-line-before": [ "always", { - except: [ - "after-declaration", - "first-nested", - ], - ignore: [ - "after-comment", - "inside-single-line-block", - ], - } ], - "function-comma-newline-after": "always-multi-line", - "function-comma-space-after": "always-single-line", - "function-comma-space-before": "never", - "function-max-empty-lines": 0, - "function-name-case": "lower", - "function-parentheses-newline-inside": "always-multi-line", - "function-parentheses-space-inside": "never-single-line", - "function-whitespace-after": "always", - "indentation": 2, - "length-zero-no-unit": true, - "max-empty-lines": 1, - "media-feature-colon-space-after": "always", - "media-feature-colon-space-before": "never", - "media-feature-name-case": "lower", - "media-feature-parentheses-space-inside": "never", - "media-feature-range-operator-space-after": "always", - "media-feature-range-operator-space-before": "always", - "media-query-list-comma-newline-after": "always-multi-line", - "media-query-list-comma-space-after": "always-single-line", - "media-query-list-comma-space-before": "never", - "no-eol-whitespace": true, - "no-missing-end-of-source-newline": true, - "number-leading-zero": "always", - "number-no-trailing-zeros": true, - "property-case": "lower", - "rule-empty-line-before": [ "always-multi-line", { - except: ["first-nested"], - ignore: ["after-comment"], - } ], - "selector-attribute-brackets-space-inside": "never", - "selector-attribute-operator-space-after": "never", - "selector-attribute-operator-space-before": "never", - "selector-combinator-space-after": "always", - "selector-combinator-space-before": "always", - "selector-descendant-combinator-no-non-space": true, - "selector-list-comma-newline-after": "always", - "selector-list-comma-space-before": "never", - "selector-max-empty-lines": 0, - "selector-pseudo-class-case": "lower", - "selector-pseudo-class-parentheses-space-inside": "never", - "selector-pseudo-element-case": "lower", - "selector-pseudo-element-colon-notation": "double", - "selector-type-case": "lower", - "unit-case": "lower", - "value-list-comma-newline-after": "always-multi-line", - "value-list-comma-space-after": "always-single-line", - "value-list-comma-space-before": "never", - "value-list-max-empty-lines": 0, - }, + "rules": + { + "at-rule-empty-line-before": + [ + "always", + { + except: ["blockless-after-same-name-blockless", "first-nested"], + ignore: ["after-comment"], + }, + ], + "at-rule-name-case": "lower", + "at-rule-name-space-after": "always-single-line", + "at-rule-semicolon-newline-after": "always", + "block-closing-brace-empty-line-before": "never", + "block-closing-brace-newline-after": "always", + "block-closing-brace-newline-before": "always-multi-line", + "block-closing-brace-space-before": "always-single-line", + "block-opening-brace-newline-after": "always-multi-line", + "block-opening-brace-space-after": "always-single-line", + "block-opening-brace-space-before": "always", + "color-hex-case": "lower", + "color-hex-length": "short", + "comment-whitespace-inside": "always", + "custom-property-empty-line-before": + [ + "always", + { + except: ["after-custom-property", "first-nested"], + ignore: ["after-comment", "inside-single-line-block"], + }, + ], + "declaration-bang-space-after": "never", + "declaration-bang-space-before": "always", + "declaration-block-semicolon-newline-after": "always-multi-line", + "declaration-block-semicolon-space-after": "always-single-line", + "declaration-block-semicolon-space-before": "never", + "declaration-block-single-line-max-declarations": 1, + "declaration-block-trailing-semicolon": "always", + "declaration-colon-newline-after": "always-multi-line", + "declaration-colon-space-after": "always-single-line", + "declaration-colon-space-before": "never", + "declaration-empty-line-before": + [ + "always", + { + except: ["after-declaration", "first-nested"], + ignore: ["after-comment", "inside-single-line-block"], + }, + ], + "function-comma-newline-after": "always-multi-line", + "function-comma-space-after": "always-single-line", + "function-comma-space-before": "never", + "function-max-empty-lines": 0, + "function-name-case": "lower", + "function-parentheses-newline-inside": "always-multi-line", + "function-parentheses-space-inside": "never-single-line", + "function-whitespace-after": "always", + "indentation": 2, + "length-zero-no-unit": true, + "max-empty-lines": 1, + "media-feature-colon-space-after": "always", + "media-feature-colon-space-before": "never", + "media-feature-name-case": "lower", + "media-feature-parentheses-space-inside": "never", + "media-feature-range-operator-space-after": "always", + "media-feature-range-operator-space-before": "always", + "media-query-list-comma-newline-after": "always-multi-line", + "media-query-list-comma-space-after": "always-single-line", + "media-query-list-comma-space-before": "never", + "no-eol-whitespace": true, + "no-missing-end-of-source-newline": true, + "number-leading-zero": "always", + "number-no-trailing-zeros": true, + "property-case": "lower", + "selector-attribute-brackets-space-inside": "never", + "selector-attribute-operator-space-after": "never", + "selector-attribute-operator-space-before": "never", + "selector-combinator-space-after": "always", + "selector-combinator-space-before": "always", + "selector-descendant-combinator-no-non-space": true, + "selector-list-comma-newline-after": "always", + "selector-list-comma-space-before": "never", + "selector-max-empty-lines": 0, + "selector-pseudo-class-case": "lower", + "selector-pseudo-class-parentheses-space-inside": "never", + "selector-pseudo-element-case": "lower", + "selector-type-case": "lower", + "unit-case": "lower", + "value-list-comma-newline-after": "always-multi-line", + "value-list-comma-space-after": "always-single-line", + "value-list-comma-space-before": "never", + "value-list-max-empty-lines": 0, + }, } diff --git a/dist/_helpers.css b/dist/_helpers.css index e4c2c58..a2e6408 100644 --- a/dist/_helpers.css +++ b/dist/_helpers.css @@ -28,8 +28,8 @@ overflow: hidden; padding: 0; position: absolute; - width: 1px; white-space: nowrap; + width: 1px; /* 1 */ } @@ -46,8 +46,8 @@ margin: 0; overflow: visible; position: static; - width: auto; white-space: inherit; + width: auto; } /* diff --git a/dist/_mqs.css b/dist/_mqs.css index 509b143..2d0d0d6 100644 --- a/dist/_mqs.css +++ b/dist/_mqs.css @@ -10,8 +10,8 @@ } @media print, -(-webkit-min-device-pixel-ratio: 1.25), -(min-resolution: 1.25dppx), -(min-resolution: 120dpi) { + (-webkit-min-device-pixel-ratio: 1.25), + (min-resolution: 1.25dppx), + (min-resolution: 120dpi) { /* Style adjustments for high resolution devices */ } diff --git a/dist/_print.css b/dist/_print.css index 6014a86..b70f2bf 100644 --- a/dist/_print.css +++ b/dist/_print.css @@ -12,7 +12,6 @@ background: transparent !important; color: #000 !important; /* Black prints faster */ - -webkit-box-shadow: none !important; box-shadow: none !important; text-shadow: none !important; } diff --git a/dist/main.css b/dist/main.css index bcbd291..0a01ce3 100644 --- a/dist/main.css +++ b/dist/main.css @@ -5,7 +5,7 @@ * Kroc Camen, and the H5BP dev community and team. */ - /* ========================================================================== +/* ========================================================================== Base styles: opinionated defaults ========================================================================== */ @@ -25,11 +25,6 @@ html { * Customize the background color to match your design. */ -::-moz-selection { - background: #b3d4fc; - text-shadow: none; -} - ::selection { background: #b3d4fc; text-shadow: none; @@ -92,26 +87,11 @@ textarea { padding: 0.2em 0; } - /* ========================================================================== +/* ========================================================================== Author's custom styles ========================================================================== */ - - - - - - - - - - - - - - - - /* ========================================================================== +/* ========================================================================== Helper classes ========================================================================== */ @@ -140,8 +120,8 @@ textarea { overflow: hidden; padding: 0; position: absolute; - width: 1px; white-space: nowrap; + width: 1px; /* 1 */ } @@ -158,8 +138,8 @@ textarea { margin: 0; overflow: visible; position: static; - width: auto; white-space: inherit; + width: auto; } /* @@ -194,7 +174,7 @@ textarea { clear: both; } - /* ========================================================================== +/* ========================================================================== EXAMPLE Media Queries for Responsive Design. These examples override the primary ('mobile first') styles. Modify as content requires. @@ -205,13 +185,13 @@ textarea { } @media print, -(-webkit-min-device-pixel-ratio: 1.25), -(min-resolution: 1.25dppx), -(min-resolution: 120dpi) { + (-webkit-min-device-pixel-ratio: 1.25), + (min-resolution: 1.25dppx), + (min-resolution: 120dpi) { /* Style adjustments for high resolution devices */ } - /* ========================================================================== +/* ========================================================================== Print styles. Inlined to avoid the additional HTTP request: https://www.phpied.com/delay-loading-your-print-css/ @@ -277,4 +257,3 @@ textarea { } } - diff --git a/package.json b/package.json index 073905c..aa090b7 100644 --- a/package.json +++ b/package.json @@ -30,7 +30,8 @@ "gulp-autoprefixer": "^6.0.0", "gulp-cssimport": "^7.0.0", "gulp-header": "^2.0.7", - "gulp-load-plugins": "^1.5.0" + "gulp-load-plugins": "^1.5.0", + "stylelint-config-recommended": "^2.1.0" }, "babel": { "presets": [ diff --git a/src/_custom.css b/src/_custom.css index f4db64f..b351c82 100644 --- a/src/_custom.css +++ b/src/_custom.css @@ -1,18 +1,3 @@ /* ========================================================================== Author's custom styles ========================================================================== */ - - - - - - - - - - - - - - - diff --git a/src/_mqs.css b/src/_mqs.css index 281baaf..4441386 100644 --- a/src/_mqs.css +++ b/src/_mqs.css @@ -9,8 +9,8 @@ } @media print, -(-webkit-min-device-pixel-ratio: 1.25), -(min-resolution: 1.25dppx), -(min-resolution: 120dpi) { + (-webkit-min-device-pixel-ratio: 1.25), + (min-resolution: 1.25dppx), + (min-resolution: 120dpi) { /* Style adjustments for high resolution devices */ } diff --git a/src/_print.css b/src/_print.css index 2926085..3bcb338 100644 --- a/src/_print.css +++ b/src/_print.css @@ -11,7 +11,6 @@ background: transparent !important; color: #000 !important; /* Black prints faster */ - -webkit-box-shadow: none !important; box-shadow: none !important; text-shadow: none !important; } diff --git a/src/main.css b/src/main.css index fcff716..a46f92e 100644 --- a/src/main.css +++ b/src/main.css @@ -4,9 +4,8 @@ * Kroc Camen, and the H5BP dev community and team. */ - @import url(_base.css); - @import url(_custom.css); - @import url(_helpers.css); - @import url(_mqs.css); - @import url(_print.css); - +@import url(_base.css); +@import url(_custom.css); +@import url(_helpers.css); +@import url(_mqs.css); +@import url(_print.css);