Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom elements seems to expect a name #10

Closed
AndreasHeintze opened this issue Aug 2, 2015 · 5 comments

Comments

Projects
None yet
2 participants
@AndreasHeintze
Copy link

commented Aug 2, 2015

If I have custom tags in my HTML where the name of the tag starts with nav, then HTML5 outliner seems to think this is a nav element and therefore it expects a name to be set. This must be wrong, isn't it?

<nav-bar>
    <nav-megamenu></nav-megamenu>
    <nav-megamenu></nav-megamenu>
    <nav-megamenu></nav-megamenu>
</nav-bar>

skarmavbild 2015-08-02 kl 13 25 42

@dominykas

This comment has been minimized.

Copy link
Member

commented Aug 3, 2015

The outliner checks for the tagName with a regex: https://github.com/h5o/h5o-js/blob/master/src/utils.js#L51 - the regex does have a ^ and a $ in there to do an exact (not a partial) match, so I wonder - how do you construct these elements? Are you extending nav? What's the actual tagName that you see in dev tools for them?

@AndreasHeintze

This comment has been minimized.

Copy link
Author

commented Aug 3, 2015

Here is a quick and simple example:
http://fiddle.jshell.net/AndreasHeintze/z7hm3xdm/2/show/

I'm using RiotJS.

@dominykas

This comment has been minimized.

Copy link
Member

commented Aug 3, 2015

Thanks, will take a look.

@dominykas

This comment has been minimized.

Copy link
Member

commented Aug 5, 2015

Fixed in 0.8.13 - available via direct install (see releases here) or as soon as Google approve it on web store.

@dominykas dominykas closed this Aug 5, 2015

@AndreasHeintze

This comment has been minimized.

Copy link
Author

commented Aug 6, 2015

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.