Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve ARIA #17

Merged
merged 6 commits into from May 15, 2019
Merged

Improve ARIA #17

merged 6 commits into from May 15, 2019

Conversation

@otacke
Copy link
Member

otacke commented Nov 4, 2018

Currently, the play button does not announce it function for readspeakers, only it's role. Also, this role will be announced over the audio that plays on click. This can make the audio difficult to understand.

If this pull request is merged in, it will

  • add a play/pause aria-label to the button (depending on its state), including fields for setting the aria-label (e.g. translations) in the editor
  • prevent the ARIA announcement over audio when starting to play on click
otacke added 5 commits Nov 4, 2018
Not fixing the flowplayer reference
- Add play/pause aria-label to button depending on state
- Prevent ARIA announcement over audio on play
"label": "Pause audio (Readspeaker)",
"common": true,
"default": "Pause audio"
},

This comment has been minimized.

Copy link
@fnoks

fnoks May 15, 2019

Member

These two new fields need to have default values set in the code (constructor), so it will be backward compatible

This comment has been minimized.

Copy link
@otacke

otacke May 15, 2019

Author Member

Added

@fnoks fnoks merged commit 4cd5ff6 into h5p:master May 15, 2019
@otacke otacke deleted the otacke:improve-aria branch May 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.