Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "go back" feature to Branching Scenario #1

Merged
merged 8 commits into from Jan 28, 2021

Conversation

otacke
Copy link
Contributor

@otacke otacke commented Jun 6, 2019

Add "go back" feature to Branching Scenario

This pull request will optionally allow users of Branching Scenario to move backwards/trace back their steps.
It adds a "back" button to library screen and a separate "back" alternative to Branching Questions that can be used to go to the previously visited nodes.

Suggestions for the UX design are welcome -- and expected ;-)

The feature was requested at https://h5p.org/comment/28203 and also at the "Technische Hochschule Lübeck", Germany.

This pull request is part of 3 separate pull requests for the branch "back_option" of

  • Branching Scenario
  • Branching Scenario Editor
  • Branching Question

Acceptance criteria

  • Authors can enable/disable the back option in a behavioral settings group
  • Users can go back one step by using a "back" button on library screens
  • "Back" button is disabled on first library screen
  • Users can retrace their steps by using a "back" alternative in Branching Questions
  • "Back" alternative is not available if first node is a Branching Question
  • Branching Scenario still reports the correct score when using dynamic scoring

Pull request details

  • Add a "behavioural" setting to optionally enable a "back" option
  • Add a l10n field for the "back" button's label
  • Add a "back" button to library screens next to the existing "proceed" button (disabled on first library screen)
  • Add a "back" alternative to Branching Questions
  • Add logic to go back steps of a complete trace including loops
  • Add logic/styles for visually sliding backwards
  • Update translation files
  • Add upgrades script to add new parameters
  • Bump minor versions
  • Also: Update npm modules
  • Also: Make eslint happy
  • Enable/disable "back" option for each single node individually (default: disable)
  • Change behavioral "back" button setting to an override with options "Use individual node settings" / "Always show" / "Always hide" (default: use individual settings)

Possible future work

  • Add button tooltip to explain why the "back" button is disabled: "There is no content to go back to." / "Going back is not allowed for this content."

@cogdog
Copy link

cogdog commented Jan 26, 2021

FWIW I'd like to upvote / applaud for this feature.

@simondate simondate merged commit 112e3aa into h5p:master Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants