Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added function to jump to interaction by clicking dots #27

Merged
merged 2 commits into from Aug 23, 2016

Conversation

@otacke
Copy link
Member

commented Jul 30, 2016

No description provided.

@thomasmars

This comment has been minimized.

Copy link
Member

commented Aug 1, 2016

Nice, I have created an issue for reviewing this PR for next release.

@thomasmars

This comment has been minimized.

Copy link
Member

commented Aug 23, 2016

Excellent, works very well!
It will need to be focusable and have keyboard events in the future, but this likely requires design, this is great for now :)

@thomasmars thomasmars merged commit 0b96131 into h5p:master Aug 23, 2016

@otacke

This comment has been minimized.

Copy link
Member Author

commented Aug 23, 2016

@thomasmars By being focusable you mean something like highlighting a dot if you hover it with the mouse pointer? And what key bindings might work? Something like Ctrl-Left and Ctrl-Right for jumping to the previous/next dot maybe?

@thomasmars

This comment has been minimized.

Copy link
Member

commented Aug 24, 2016

@otacke Yes, what I mainly meant was that it should have relevant button states: hover, focus and active. It should also be keyboard focusable/have a tabindex, and it should have a keyevent for selection with space/enter, or be transformed into a semantically correct html element, such as button, since it is now a div. Hotkey navigation might be convenient as well.

@otacke

This comment has been minimized.

Copy link
Member Author

commented Aug 24, 2016

@thomasmars Thanks for the clarification. I never made a secret of my coding skills "leaving room for improvement" ;-) I think now is the time that I should really have a proper look at a good book/website about JavaScript/CSS - I'd have to look up the difference between hover, focus and active.

@thomasmars

This comment has been minimized.

Copy link
Member

commented Aug 24, 2016

@otacke Your coding skills are excellent as far as I can tell, looks clean and logical :)
We always have to keep in mind that web pages should be accessible for anyone, whichever device or assistive technologies they may be using. Interactive Video has not received enough love in this regard, but hopefully we can address it soon. I think google developers has some decent introduction videos on accessibility if you wanna check it out.
Big thanks for the contribution, I'm sure it will be useful for a lot of people!

@otacke

This comment has been minimized.

Copy link
Member Author

commented Aug 24, 2016

I will check it out! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.