Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Fullscreen in Safari 10 not working #34
First of all; great work guys, really like your elements and components. We hope to contribute in the near future. A customer was reporting issues with Safari 10 and fullscreen. After debugging I also came across this drupal website, where a user has found the root cause and solution.
The problem is the detection of the Safari version. As they now have version 10 (2 digits), your regular expression is only taking 1 digit, so it sees it as Safari < 7 and no real full screen is enabled. But is also not enabling the semi full screen modus (as @paalj there is asking), thus the button is not doing anything.
Version 8 and 9 of Safari are working fine, as I just checked it with Browserstack.
If I can assist in any way, let me know.