New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Payloads disabled in expand/collapse group #350

Closed
rok5ek opened this Issue Feb 10, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@rok5ek

rok5ek commented Feb 10, 2017

It would be of great help if we could add a payload in methods expandGroup and collapseGroup. As I can see the notifyItemChanged(flatPosition) is called, which means we cannot add a payload and do some custom animations more robustly.

@rok5ek rok5ek changed the title from Payload not working in notifyItemChaned to Payload not working in notifyItemChanged Feb 10, 2017

@rok5ek rok5ek changed the title from Payload not working in notifyItemChanged to Payload not working in expand/collapse group Feb 10, 2017

@rok5ek rok5ek changed the title from Payload not working in expand/collapse group to Payloads disabled in expand/collapse group Feb 10, 2017

@h6ah4i h6ah4i added the enhancement label Feb 11, 2017

@h6ah4i

This comment has been minimized.

Show comment
Hide comment
@h6ah4i

h6ah4i Feb 11, 2017

Owner

Hi. Thanks for a good suggestion. I will include this enhancement on next release!

Owner

h6ah4i commented Feb 11, 2017

Hi. Thanks for a good suggestion. I will include this enhancement on next release!

@h6ah4i h6ah4i added this to the next release milestone Feb 11, 2017

h6ah4i added a commit that referenced this issue Feb 19, 2017

[BREAKING CHANGE] Add "payload" parameter to expandGroup() and collap…
…seGroup() (#350)

This commit also changes OnGroupExpandListener and OnCollapseExpandListener.
These two listeners now have the payload parameter and it's a breaking syntax change.

@h6ah4i h6ah4i self-assigned this Feb 19, 2017

@h6ah4i

This comment has been minimized.

Show comment
Hide comment
@h6ah4i

h6ah4i Feb 25, 2017

Owner

@rok5ek This feature has been merged and released as v0.10.4 now.

Owner

h6ah4i commented Feb 25, 2017

@rok5ek This feature has been merged and released as v0.10.4 now.

@h6ah4i h6ah4i closed this Feb 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment