Parent theme's action_template_header doesn't run when child is active

[michaeltwofish]

Create a child theme with Wazi as the parent and no other files. When the child theme is active Wazi's action_template_header() should run the same as if Wazi was active but it does not. Other templates are included correctly.

[michaeltwofish]

Looking at Plugins::register(), the template_header hook is never registered when the child theme is active.

[michaeltwofish]

I suspect we need a Pluggable::load_hooks($parent_theme_class) or something similar around https://github.com/habari/system/blob/master/classes/themes.php#L339

[michaeltwofish]

Or we just instantiate the parent, and the constructor will handle loading the hooks.

[michaeltwofish]

Not a bug, it just didn't work how I expected it to work. Extending the parent theme in theme.php instead of Habari's Theme class causes the hooks to be registered.

[Konzertheld]

I don't see how this is fixed or not a bug? The parent theme.php should run when there is no child theme.php, it does not, at least not action_template_header(). So a child theme.php is always required.

[miklb]

The wiki clearly is documented as saying a parent theme's theme.php would run if none is present in the child theme. Definitely seems what the intended behavior was, so I'd say it's a bug.