Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api raml update #1698

Merged
merged 7 commits into from
Feb 2, 2022
Merged

api raml update #1698

merged 7 commits into from
Feb 2, 2022

Conversation

pozsgaic
Copy link
Contributor

Fix issue in format of original file
Manual convert to 1.0
Backfill missing content that is implemented in code

Signed-off-by: pozsgaic <pozsgai@progress.com>
@pozsgaic pozsgaic marked this pull request as ready for review January 21, 2022 19:34
@mwrock
Copy link
Contributor

mwrock commented Jan 22, 2022

Would it be possible to see the missing content additions and the conversion to 1.0 as separate commits or PRs. With do many changes, its hard to tell here what changed from the converter and what is a true content change.

@pozsgaic
Copy link
Contributor Author

Sure - will do

pozsgaic added 2 commits January 24, 2022 07:23
Signed-off-by: pozsgaic <pozsgai@progress.com>
Signed-off-by: pozsgaic <pozsgai@progress.com>
sajjaphani and others added 2 commits January 27, 2022 21:15
Signed-off-by: Phani Sajja <psajja@progress.com>
Signed-off-by: pozsgaic <pozsgai@progress.com>
@sajjaphani
Copy link
Contributor

The following sub-routes have a /depot as a prefix.

/origins
/pkgs
/events
/{origin}
/channels

Examples:
URI: /depot/{origin}/pkgs
Full URL: https://bldr.habitat.sh/v1/depot/{origin}/pkgs
URI: /depot/origins/{origin}
Full URL: https://bldr.habitat.sh/v1/depot/origins/{origin}

@pozsgaic
Copy link
Contributor Author

pozsgaic commented Jan 28, 2022

I did observe that depot was not present. Not sure if it was omitted intentionally in the baseline api.raml, but I opted not to
try to fix everything that was not done correctly. I was aiming more to backfill missing content.
I will take a look and see - hopefully we can add it in with sed or other tool without much effort.

pozsgaic added 2 commits January 30, 2022 09:33
Signed-off-by: pozsgaic <pozsgai@progress.com>
Signed-off-by: pozsgaic <pozsgai@progress.com>
@pozsgaic pozsgaic merged commit 2fb6c42 into main Feb 2, 2022
@pozsgaic pozsgaic deleted the cjp/api_raml_update branch February 2, 2022 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants